New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scss: gradient in $topbar-bg #2111

Closed
dersvenhesse opened this Issue Apr 4, 2013 · 6 comments

Comments

Projects
None yet
5 participants
@dersvenhesse

dersvenhesse commented Apr 4, 2013

Though it's possible to change the topbars color in line 979 in _.settings.css there is no possibility to use a gradient. You are lighten the color in line 415 in _top-bar.scss (background: lighten($topbar-bg, 5%);). This impossible with a gradient like +gradient(#333, #555);.

Please set the lightening as an option to allow gradients.

@timscott

This comment has been minimized.

Show comment
Hide comment
@timscott

timscott May 1, 2013

This is needed.

timscott commented May 1, 2013

This is needed.

@ghost ghost assigned hatefulcrawdad May 6, 2013

@Sigler

This comment has been minimized.

Show comment
Hide comment
@Sigler

Sigler May 8, 2013

This is also an issue if you want to use "transparent" for $topbar-bg. :(

I would recommend making the highlight color a separate variable, such as $topbar-bg-hover.

Sigler commented May 8, 2013

This is also an issue if you want to use "transparent" for $topbar-bg. :(

I would recommend making the highlight color a separate variable, such as $topbar-bg-hover.

@Sigler

This comment has been minimized.

Show comment
Hide comment
@Sigler

Sigler May 8, 2013

As a work around on the transparency issue it looks like rgba(0,0,0,0) works with the lighten and darken functions.

There is a similar issue with topbar-dropdown-bg. I'm sure there are more.

What do guys think of defining the :hover pseudo-selectors a separate variable? We could still use lighten and darken functions as the defaults. Users could easily override them without having to alter the original .scss file.
Could fix the bg-color issue at the same time.

Happy to tinker and contribute if anyone is interested.

Sigler commented May 8, 2013

As a work around on the transparency issue it looks like rgba(0,0,0,0) works with the lighten and darken functions.

There is a similar issue with topbar-dropdown-bg. I'm sure there are more.

What do guys think of defining the :hover pseudo-selectors a separate variable? We could still use lighten and darken functions as the defaults. Users could easily override them without having to alter the original .scss file.
Could fix the bg-color issue at the same time.

Happy to tinker and contribute if anyone is interested.

@timscott

This comment has been minimized.

Show comment
Hide comment
@timscott

timscott May 9, 2013

FYI. I have hacked a solution as follows. In settings:

$topbar-bg: rgba(0,0,0,0)
$topbar-dropdown-bg: rgba(212,216,224, 0.3);

Then in app.css:

ul.dropdown { 
    rgb(212,216,224)
}
#global-nav {
   // gradient styles
}

timscott commented May 9, 2013

FYI. I have hacked a solution as follows. In settings:

$topbar-bg: rgba(0,0,0,0)
$topbar-dropdown-bg: rgba(212,216,224, 0.3);

Then in app.css:

ul.dropdown { 
    rgb(212,216,224)
}
#global-nav {
   // gradient styles
}
@hatefulcrawdad

This comment has been minimized.

Show comment
Hide comment
@hatefulcrawdad

hatefulcrawdad May 19, 2013

We'd love for someone to tinker with this in a PR so that we can get it merged in at some point.

hatefulcrawdad commented May 19, 2013

We'd love for someone to tinker with this in a PR so that we can get it merged in at some point.

@rvinay88

This comment has been minimized.

Show comment
Hide comment
@rvinay88

rvinay88 Aug 29, 2013

Contributor

Please track #3127 (commits)
Will close this issue for now

Contributor

rvinay88 commented Aug 29, 2013

Please track #3127 (commits)
Will close this issue for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment