Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don´t use variables for black and white #7383

Closed
jmartsch opened this issue Dec 3, 2015 · 3 comments

Comments

4 participants
@jmartsch
Copy link

commented Dec 3, 2015

They are absolute colors and not to be redefined.
So please remove them from _global.scss and use other variables instead.

If someone wants to use another color, the variable name would not match and isn´t semantically correct.

@aibrean

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2015

The only reason I can see for using them as variables is lighten/darken.

@zurbrandon

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2015

The reason we do this is because white and black are both subjective colors in a sense. It makes it easier for someone to use #fefefe as their main white, if they choose as we do this often.

@gakimball

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2015

We're giving developers the flexibility to modify what "black" and "white" mean in their design. They might not be semantic names like $primary-color, but the key is that they're constants. We don't use hex colors anywhere in the default framework styles, to ensure that we're using a small, consistent color palette.

@gakimball gakimball closed this Dec 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.