Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

How is vertical rhythm handled? #947

Closed
chrisnicola opened this Issue Sep 26, 2012 · 4 comments

Comments

Projects
None yet
3 participants

From what I can tell there is no baseline or vertical rhythm unit. Just the modular scale, which defines the scale of the fonts, but the baseline is different for each size.

I'd be happy to work on applying the Compass vertical rhythm mixin to fix this.

The rhythm is defined by the modular scale as well sort of. We'd definitely be interested in seeing how you incorporate the compass mixin because we found it kind of hard to use.

heh, yes it is very hard to use. I can post a gist of what I did. I actually just ended up relying on px instead because ems (the default in compass) creates a whole bunch of problems for setting margins, padding, etc. So I suppose it isn't a big deal and doesn't necessarily need to be built in but it might be good to set as the initial defaults or perhaps a setting.

Compas is rewriting the VR mixin to use rems with a fallback to px which will be much better so when that happens I'll probably switch back.

By itself though, modular scale does not define a baseline rhythm, just relative font sizes. Vertical rhythm requires all line-heights and margin/padding to add up to a multiple of the base line height. These rules are made to be broken but are really good to apply in most places.

Closing this as an issue for now since the PR will do enough to remind me to include this soon! I haven't gotten in there to test it out yet, but I'll try to do that next week so that we can include this ASAP.

rawtaz commented Sep 21, 2013

What's the status of this stuff? Did anything for vertical rhythm get included in F4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment