Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slider: add support for changing by clicking on the slider without having started to drag from the handle #6695

Merged
merged 1 commit into from Sep 1, 2015

Conversation

Projects
None yet
3 participants
@Burtchen
Copy link
Contributor

commented Jul 10, 2015

The idea is that in many other implementation of a slider, it's possible to directly click/tap on a target value to change the slider, rather than to grab the handle first, which can be a bit annoying. There's a bit of almost-duplicate code compared to the mousemove event handler, but it seemed overkill to create another function before get_cursor_position for this.

slider: add support for changing a value by clicking on the slider wi…
…thout having started to drag from the handle

@rafibomb rafibomb added this to the 5.5.3 milestone Sep 1, 2015

rafibomb added a commit that referenced this pull request Sep 1, 2015

Merge pull request #6695 from Burtchen/slider-without-drag
slider: add support for changing by clicking on the slider without having started to drag from the handle

@rafibomb rafibomb merged commit b148637 into zurb:master Sep 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rafibomb

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2015

Thanks! We love this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.