Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: added .alert, .warning and .success colors to switch input #8065

Closed
wants to merge 1 commit into from

Conversation

foglcz
Copy link

@foglcz foglcz commented Feb 3, 2016

Type Feature
Fixes issues n/a
Documentation updated
BC Break no

In our internal intranet, we have a shipping dispatch form built with Foundation.

In there, we have various checkboxes that update ERPs / suppliers interfaces / databases / etc. I wanted to bring one of those checkboxes to users attention when checked (since default is off, and when on, it does a lot of things behind the scenes).
Intuitively, I tried adding "warning" class to the checkbox label.... and nothing happened.

This fixes the "issue", if you agree that this might/should be part of standard.

Currently I'm using following in my app.scss tu spplement the feature:

input:checked~.switch-paddle.alert { background: $alert-color; }
input:checked~.switch-paddle.warning { background: $warning-color; }
input:checked~.switch-paddle.success { background: $success-color; }

Let me know if this makes sense / you would want to somehow update this.

Thanks!
Pavel

@gakimball gakimball added the scss label Feb 3, 2016
@andycochran
Copy link
Contributor

@gakimball, would this be better done with a mixin and app-specific CSS? Especially considering flexible color palettes #7219 (comment), and to avoid hard-coded the classes.

@gakimball
Copy link
Contributor

Thanks for the PR! :) Unfortunately, we aren't interested in adding coloring classes to switches at the moment, as the use-case is fairly narrow.

@gakimball gakimball closed this Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants