New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.2.2 fixes abide radio check if only one radio is required #8783

Merged
merged 1 commit into from May 13, 2016

Conversation

Projects
None yet
2 participants
@designerno1
Collaborator

designerno1 commented May 13, 2016

fixes bug when only one radio has required and adds a visual test for that

according to docs from jQuery http://api.jquery.com/attr/
Get the value of an attribute for the first element in the set of matched elements or set one or more attributes for every matched element.

// .attr() returns undefined if no elements in $group have the attribute "required"
if ($group.attr('required') === undefined) {
  valid = true;
}
@kball

This comment has been minimized.

Show comment
Hide comment
@kball

kball May 13, 2016

Collaborator

👍

Collaborator

kball commented May 13, 2016

👍

@kball kball merged commit 5a7686d into zurb:v6.2.2 May 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@designerno1 designerno1 deleted the designerno1:v6.2.2-abide-radio-fix branch May 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment