Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorize breakpoints map handling #9439

Merged
merged 4 commits into from Dec 5, 2016

Conversation

3 participants
@ncoden
Copy link
Member

commented Dec 3, 2016

Fix #9425 - Factorize the handling of breakpoints map in grid-column-gutter and grid-column-margin mixins.

Changes:

  • Add @mixin -zf-breakpoint-value which generate its content with the value $-zf-bp-value depending on its parameter, like @mixin grid-column-gutter and @mixin grid-column-margin did (see the @mixin -zf-breakpoint-value doc)
  • Use @mixin -zf-breakpoint-value in @mixin grid-column-gutter and @mixin grid-column-margin and remove duplicated code.
  • Allow @function -zf-get-bp-val to take a single value as responsive config $map and return it regardless of $value.
  • Remove useless @function grid-column-gutter

ncoden added some commits Dec 3, 2016

Factorize breakpoint map handling in grid gutters and margins
Factorize breakpoint map handling in `grid-column-gutter` and
`grid-column-margin` mixins.

Changes:
- Add the `-zf-breakpoint-value` mixin which generate its content with
the value `$-zf-bp-value` depending on its parameter, like
`grid-column-gutter` and `grid-column-margin` did (see the `@mixin
-zf-breakpoint-value` doc)
- Use the `-zf-breakpoint-value` mixin in `grid-column-gutter` and
`grid-column-margin` and remove duplicated code.
- Rename the `grid-column-gutter` function to `-zf-breakpoint-value`
and move it to `/scss/util/_breakpoint.scss`. This function had a
generic behaviour.
Factorize function -zf-breakpoint-value into -zf-get-bp-val
- Allow the `-zf-get-bp-val` function to take a single value as
responsive config `$map` and return it regardless of `$value`.
- Remove useless function `-zf-breakpoint-value`

@ncoden ncoden added the scss label Dec 3, 2016

@ncoden

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2016

@andycochran What do you think ?

@andycochran

This comment has been minimized.

Copy link
Collaborator

commented Dec 3, 2016

Nice. I think this works, so long as we're okay with breaking any apps that currently make use of the grid-column-gutter() function.

@ncoden

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2016

@andycochran @function grid-column-gutter was introduced in 948ddd5 (#8528) for zurb:v6.3. But I can depreciate with a warning instead of deleting it, and we will remove it in 6.4 ?

(poke @kball)

@andycochran

This comment has been minimized.

Copy link
Collaborator

commented Dec 4, 2016

Oh, it's a new function? Nix it.

@kball kball merged commit 7245cf9 into zurb:develop Dec 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ncoden ncoden deleted the ncoden:refactor/bp-values-map branch Apr 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.