Setting up a vertical rhythm for typography with compass #954

Closed
wants to merge 18 commits into
from
Commits on Sep 27, 2012
  1. Setting up a vertical rhythm for typography with compass

    Chris Nicola committed Sep 27, 2012
    This uses the compass vertical rhythm mixin to setup the typography
    settings in addition to modular scale. The fonts and line-heights are
    set in pixels to make this work sensibly. When Compass changes to
    support rems with a pixel fall back that can be used instead.
    
    I've also added class based font sizes so that font sizes can be used
    regardless of header level. It isn't all that common that H1 is always
    the same size in all contexts and with the new HTML5 sematics it will be
    pretty common for most headings in a hierarchy of content to be H1's.
Commits on Sep 29, 2012
  1. Adjust a few more margins to complete the vertical ryhthm

    Chris Nicola committed Sep 29, 2012
    Also loosen the rules to allow half lines for the line-heights of larger
    fonts. This means the line-heights increase from 22px, 33px, 44px, 55px
    instead of 22px, 44px, 66px. This is almost undetectable visually but
    avoids large gaps between lines for certain header sizes.
Commits on Sep 30, 2012
  1. Vertical rhythm for ui components

    Chris Nicola committed Sep 30, 2012
  2. Adjust horizontal rule VR to compenstate for 1px border

    Chris Nicola committed Sep 30, 2012
Commits on Oct 5, 2012
  1. Setup VR for form elements adjust buttons slightly

    Chris Nicola committed Oct 5, 2012
    I won't be setting a VR for buttons because the sizes don't quite work
    right. It will be up to users to decide how they want their button to
    fit in the vertical grid by setting margins as needed.
  2. Set $topBarHeight to $baseLineHeight * 2

    Chris Nicola committed Oct 5, 2012
  3. Fix line-height setting on all elements

    Chris Nicola committed Oct 5, 2012
  4. Adjust navigation elements for vertical rhythm

    Chris Nicola committed Oct 5, 2012
  5. Vertical rhythm setup for tabs

    Chris Nicola committed Oct 5, 2012
  6. Tweaking typography to absolute pixel perfection

    Chris Nicola committed Oct 5, 2012
  7. Adjust grid typography and adjust grid demo for borders

    Chris Nicola committed Oct 5, 2012
    The block-grid has been given consistent top and bottom padding to keep
    it in rhythm. I'm not sure if this breaks a desired effect with the
    smaller padding sizes as blocks became smaller.
  8. Fixes prefix and postfix style buttons.

    Chris Nicola committed Oct 5, 2012
  9. Fixing up VR for form elements specifically fieldsets and custom

    Chris Nicola committed Oct 5, 2012
    Noticed a problem with a <br/> under the custom checkbox area in the
    demo. It is overlapping the previous row causing it to report height
    incorrectly. A div with a space in it works though.
Commits on Oct 6, 2012
  1. Comment out vertical rhythm debugging lines

    Chris Nicola committed Oct 6, 2012
Commits on Dec 1, 2012
  1. Merge tag 'v3.2.2' into vertical-rhythm

    chrisnicola committed Dec 1, 2012
    Version 3.2.2
    
    Conflicts:
    	scss/foundation/_settings.scss
    	scss/foundation/common/_forms.scss
    	scss/foundation/common/_typography.scss
    	scss/foundation/components/_grid.scss
    	scss/foundation/components/modules/_tabs.scss
    	scss/foundation/components/modules/_topbar.scss
    	scss/foundation/components/modules/_ui.scss
    	test/forms.html
Commits on Dec 2, 2012