Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Forms doc labels not accessible #133

Closed
ricklowes opened this Issue · 5 comments

4 participants

@ricklowes

Was just looking at the markup for your Forms doc - I don't believe these are coded to proper practice for accessibilty - the form input labels need to be either explicitly related to the input field (using the "for" attribute) or implicitly by including the input element inside the label element.

So for example this markup:

<label>Standard Input</label>
<input type="text" class="input-text" />

Should be like this (in order to make an 'explicit' relationship, which I believe is recommended):

<label for="standard-input">Standard Input</label>
<input id="standard-input" type="text" class="input-text" />

This should be done throughout the Forms doc since many people will simply cut/paste this markup, and it's easy to add in these accessibility best practices as examples. There are likely other best practices as well to include in the forms, but just noted this one quickly so wanted to pass it on.

@smileyj68

Good point Rick - we'll make that change shortly. Definitely true plenty of people will cut/paste, so it's good to show the right way to do it. If you see anything else like that let us know.

@allanwhite

@ricklowes - got a link to a good overview of accessibility best practices?

@ricklowes
@smileyj68

We updated this in the docs, and I'm saving this as FAQ for future reference. We're going to keep working on accessibility for the next rev.

@smileyj68 smileyj68 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.