Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Reveal Sizes in Docs #2135

Closed
ascottmccauley opened this Issue · 2 comments

3 participants

@ascottmccauley

Just a quick not that the foundation docs list
tiny: Set the width to 30%.
small: Set the width to 40%.
medium: Set the width to 60%.
large: Set the width to 70%.
xlarge: Set the width to 95%.

but the scss file instead has:
&.small { @include reveal-modal-base(false, 30%); }
&.medium { @include reveal-modal-base(false, 40%); }
&.large { @include reveal-modal-base(false, 60%); }
&.xlarge { @include reveal-modal-base(false, 70%); }
&.expand { @include reveal-modal-base(false, 95%); }

I'm not sure which way you want to go, otherwise I would push a commit.

@mrsweaters
Owner

Let's go with the way it is written in the code. Can you do a pull request to update the docs with this:

&.small { @include reveal-modal-base(false, 30%); }
&.medium { @include reveal-modal-base(false, 40%); }
&.large { @include reveal-modal-base(false, 60%); }
&.xlarge { @include reveal-modal-base(false, 70%); }
&.expand { @include reveal-modal-base(false, 95%); }

Thank you for reporting this.

@hatefulcrawdad hatefulcrawdad closed this issue from a commit
zurbchris Closes #2135 b133c84
@dioklecijan

I'm just testing reveal-modal in 5.02. and looks like that xlarge and expand are replaced:

&.xlarge { @include reveal-modal-base(false, 95%); }
&.expand { @include reveal-modal-base(false, 70%); }

instead of

&.xlarge { @include reveal-modal-base(false, 70%); }
&.expand { @include reveal-modal-base(false, 95%); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.