Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Bar Breakpoint Visibility #6538

Closed
wants to merge 5 commits into from

Conversation

vita10gy
Copy link

@vita10gy vita10gy commented May 8, 2015

Discussed in #6248

Add visibility classes based on top-bar's breakpoint.

Make top-bar show and hide parent-links based on these new visibility
classes instead of medium.

Add grid classes based on top-bar breakpoint. (Optional - off by
default)

Add visibility classes based on top-bar's breakpoint.

Make top-bar show and hide parent-links based on these new visibility
classes instead of medium.

Add grid classes based on top-bar breakpoint. (Optional  - off by
default)
@vita10gy
Copy link
Author

vita10gy commented May 9, 2015

If this gets pulled I'd also be willing to update any documentation, but no point in doing that now, since things might change. Also, frankly, I'm not sure what I'd need to change. I'm guessing at least some of it must pull the scss directly.

Breaks "show-for-medium-only", for example
Add table cases for new classes and make small tweak to topbar
@rafibomb rafibomb added this to the 5.5.3 milestone Sep 22, 2015
@rafibomb
Copy link
Member

Hey, thanks for the PR. Sorry this has sat a while. We're working on getting Foundation 6 out for public launch therefor we're only merging bug fixes. New features are not on the roadmap because we're making sure the final release of Foundation 5 is very stable. We'll close this here. Focusing on bugs and Foundation 6. Thanks!

@rafibomb rafibomb closed this Oct 13, 2015
@vita10gy
Copy link
Author

I think one could argue the fact that topbar doesn't use the topbar breakpoint in a decision point and instead has an entirely different one hardcoded into it is indeed a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants