Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

The 'defaults' are overridden with $.extend(true, defaults, opts) #95

Open
jackquack opened this Issue · 0 comments

1 participant

@jackquack

This is bad, because you can't destroy the current joyride, and then start a new one. Joyride will fault because the defaults objects will contain properties from the old joyride.

For instance :

settings.$li === undefined

will be false. Thus, the show() method will fail to execute as expected.

You can fix this by implementing a utility function like underscores library's _.defaults(object1, object2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.