Adding modal background option, and an expose element feature #72

Merged
merged 4 commits into from Mar 21, 2013

Conversation

Projects
None yet
4 participants
Contributor

ehudokai commented Feb 7, 2013

added a modal option for those that want the page darkened out during the tour.

created an expose feature to expose the highlighted elements that are covered by the modal during the tour. see screenshot...

expose_on_modal

added 2 options to turn these features on and off.

modal: false(default) // setting this to true makes the whole tour happen over a modal background
expose: false(default) //setting this and modal to true causes the element to be exposed during a modal'd tour as seen in the screenshot.

I also added 3 more callbacks: preRideCallback, preStepCallback, and postExposeCallback

didn't change any filenames or versions, but since I wrote this and its very helpful to me I figured I'd share :)

cm0s and others added some commits Mar 14, 2013

@cm0s cm0s test if li element is defined before calling pos_phone or pos_default…
… functions to avoid undefined error when resizing the window.
78b0921
@mrsweaters mrsweaters Merge pull request #87 from cm0s/master
Avoid Uncaught TypeError: Cannot call method 'offset' of undefined error when using autoStart: false
d17e67f
@mrsweaters mrsweaters Merge pull request #93 from bradhuffman/master
Updated demo.html to autoStart joyride.
670c9e6
Owner

mrsweaters commented Mar 21, 2013

I would like to merge this in. Can you please update your pull request?

Contributor

ehudokai commented Mar 21, 2013

I'll get that done.

Contributor

ehudokai commented Mar 21, 2013

Sorry, I keep forgetting to change my commit id. If you want I can fix that too... But it is updated now.

@ehudokai ehudokai Added a modal background option, and an expose feature
to expose elements on the tour
also added postRide, postStep, and postExpose callbacks

Change-Id: I5717903e8b040388ad3400271c7c71e49bd89c46
cb0d25d

ehudokai closed this Mar 21, 2013

Contributor

ehudokai commented Mar 21, 2013

sorry, was fixing commit ids and deleting my own master caused the pull request to get closed ... whoops... rerequest

ehudokai reopened this Mar 21, 2013

Owner

mrsweaters commented Mar 21, 2013

Haha, thanks!

@mrsweaters mrsweaters added a commit that referenced this pull request Mar 21, 2013

@mrsweaters mrsweaters Merge pull request #72 from ehudokai/master
Adding modal background option, and an expose element feature
ed4fbe7

@mrsweaters mrsweaters merged commit ed4fbe7 into zurb:master Mar 21, 2013

jsmestad referenced this pull request in zurb/foundation-sites Apr 2, 2013

Closed

Update foundation.joyride.js #2084

Hamdan85 commented Mar 4, 2014

Is only with me or now, every step (with modal: true) is getting the fogged background?
I would like to turn the fog off for non modal events like the demo on foundation website... what happened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment