++ For next update #17

Open
vedovatto opened this Issue Jul 29, 2011 · 3 comments

Comments

Projects
None yet
2 participants

My implamentations:

BG supor for IE7

if(modalBG.length == 0) {
modalBG = $('

').insertAfter(modal);
$('.reveal-modal-bg').fadeTo('fast', 0.7);
}

-- Replace all for suport load() - AJAX

visibility > display
visible > block
hidden > none

-- fire from click
click() >> .live({'click', ...})

One Bug - I am not resolved...

At load from ajax //////////////

$('#myModal').reveal();
$('#target').load("my_content.php);

If fire new modal into #target, the first event not close. It's necessaire for internal controls in my_content.php. Example open modal from outher modal...

Collaborator

mkelly12 commented Aug 1, 2011

Thanks for the suggestions, but I'm not sure I quite follow all of them.

Is the background change a fix to a bug in IE7? Or just a stylistic change?

Not sure what you mean by

visibility > display
visible > block
hidden > none

About using live instead of binding to the element, we use live to bind to links on the page to open the modal, since those links may have been generated with JavaScript after the reveal script was loaded. We bind directly to the element to close the modal, but that binding is done every time the modal is opened, so I'm not sure what the advantage of live would be there.

For the last bug you listed, is it possible to close the first modal by triggering the close event on it?

Hello ,

Yes, the background change a fix to a bug in IE7, this version show black
background in IE7. ;-)

Thanks for you return.

Diego

2011/8/1 mkelly12 <
reply@reply.github.com>

Thanks for the suggestions, but I'm not sure I quite follow all of them.

Is the background change a fix to a bug in IE7? Or just a stylistic change?

Not sure what you mean by

visibility > display
visible > block
hidden > none

About using live instead of binding to the element, we use live to bind to
links on the page to open the modal, since those links may have been
generated with JavaScript after the reveal script was loaded. We bind
directly to the element to close the modal, but that binding is done every
time the modal is opened, so I'm not sure what the advantage of live would
be there.

For the last bug you listed, is it possible to close the first modal by
triggering the close event on it?

Reply to this email directly or view it on GitHub:
#17 (comment)

Collaborator

mkelly12 commented Aug 1, 2011

Nice, fixed in 2a9577d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment