New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates Working Test Suite #199

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
2 participants
@rcavezza
Copy link
Contributor

rcavezza commented Feb 10, 2019

This gets the test suite working when you run npm test. This creates a watcher that will run the tests each time you change a file. I also installed a few plugins to help display failing/passing tests in a friendly manner. There's the jasmine html reporter and spec reporter. One creates a browser window that shows passing/failing tests, and the other shows them in the console.

I spent a lot of trial & error learning browserify, karma, and babel today. Although the footprint looks small - this took up most of my Saturday. 馃槃

Jasmine Html Reporter Output

screen shot 2019-02-09 at 8 14 02 pm

Karma Spec Reporter Console Output

screen shot 2019-02-09 at 8 14 17 pm

Commit messages:

  • Updates test files to get them running while instantiating Tribute in the base case. Adds in some helpers to help debug failing tests. Installs a few npm packages to help achieve these desired outcomes.
Updates test files to get them running while instantiating Tribute in鈥
鈥 the base case. Adds in some helpers to help debug failing tests. Installs a few npm packages to help achieve these desired outcomes.
@rcavezza

This comment has been minimized.

Copy link
Contributor Author

rcavezza commented Feb 12, 2019

@mrsweaters Do we have guidelines for getting approval and merging in PRs? I'd like to get this merged in so I can write some tests for my other PR.

@mrsweaters

This comment has been minimized.

Copy link
Member

mrsweaters commented Feb 12, 2019

@rcavezza This looks great! Thanks for doing the heavy lifting here. We don't currently have any specific guidelines here. Right now we have 4 space tabs (which I'd like to eventually change to two) and no semicolons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment