Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of the 1.0 release, adds in AngularJS support, removes runtime dependencies, etc. #46

Closed
wants to merge 32 commits into from

Conversation

mhayes
Copy link
Contributor

@mhayes mhayes commented Feb 12, 2016

Hey guys - this PR adds in a bunch of changes to the TwentyTwenty plugin. Most notably:

  • Adds in support for AngularJS, so there is now a jQuery and AngularJS version
    • All common functionality has been moved into src/js/core.js to prevent too much redundant code in the different plugin versions
  • Removes dependencies on external touch libraries (i.e. ngTouch for AngularJS or jquery.event.move for jQuery)
  • Uses webpack for the build system resulting in a single JS file, there is no need to include a CSS in your project

I see this as the starting ground for a 2.0 release of the plugin. Would love to hear thoughts of other things that can be part of this release.

mhayes and others added 28 commits October 31, 2015 11:36
news update
add thanks to section to README
…e state, remove all dependencies on external touch plugins
@rafibomb
Copy link
Contributor

Awesome! Great work! We used Twenty Twenty recently in the Foundation for Emails blog post

I'll ask the engineers who are more knowledgeable than I to check it out!

@raphaeleidus
Copy link
Contributor

hey @mhayes this is no longer mergeable.
When you first opened the PR you moved some files around, introducing a src folder, unfortunately you didn't use git mv so the diff shows as you deleting the entire file and the adding a new one, this destroys the history for the files so I wont be able to merge this even with it touched up to resolve conflicts. If you are still interested in what v2 could be let me know I think you have some great ideas here.

@mhayes
Copy link
Contributor Author

mhayes commented Jun 9, 2017

Hey @raphaeleidus thanks for following up with me. I've actually switched over to using VueJS for most of my work these days (also ported TwentyTwenty to VueJS here: https://github.com/mhayes/vue-twentytwenty) so not looking to make any updates on this.

Cheers!

@raphaeleidus
Copy link
Contributor

raphaeleidus commented Jun 9, 2017

cool. that makes sense. I am definitely going to review this and pull some items from it. Thank you for the great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants