Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip with compression #80

Merged
merged 2 commits into from Nov 15, 2019

Conversation

@aaronmcox
Copy link
Contributor

aaronmcox commented Nov 15, 2019

On a whim, looked into #61. grunt-zip didn't seem to support compression, but https://github.com/gruntjs/grunt-contrib-compress did.

With master, my zip files using the existing zip and the new compress tasks have exactly the same contents using unzip -l, sort, and diff.

@aaronmcox

This comment has been minimized.

Copy link
Contributor Author

aaronmcox commented Nov 15, 2019

added my new zip to a test site, as far as I can tell it looks and functions the same.

@zutrinken zutrinken merged commit b3e82b9 into zutrinken:master Nov 15, 2019
@zutrinken

This comment has been minimized.

Copy link
Owner

zutrinken commented Nov 15, 2019

@aaronmcox Looks good. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.