This repository has been archived by the owner on Dec 19, 2017. It is now read-only.
DISCUSS: statusBarHeight is incorrect on iOS 7 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry for the slow response. I haven't synced DZPopupController with our internal copies in a while. The [REDACTED] status bar behavior gets extremely wonky on 7. The nudge of 20 is correct, but I agree that the result is incorrect so I'll merge it anyway. (Thanks!) |
zwaldowski
added a commit
that referenced
this pull request
Sep 10, 2013
DISCUSS: statusBarHeight is incorrect on iOS 7
|
And, that is to say, I'll keep an eye out for improvements to be made. I haven't worked on DZPopupController's specific iOS 7 support since Beta 2 or thereabouts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you've seen this before, but for some reason on iOS 7, the statusBarHeight "nudge" of 20 (the one that occurs in viewDidLoad) seems like half as much as what is actually required. If you present a blank DZPopupController, you should see it cutting the status bar in half.
Now, this fix really makes no sense; rects are always specified in 1x, so the scale should have nothing to do with it, but it felt better than hardcoding 2. I've also fiddled with all of the new iOS properties (which are NDAed, otherwise I'd list them here) that control whether we overlap the status bar or not (holy hell do they feel half-baked) to no avail.
Has anyone else seen this behavior?