Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip JSON #9

Merged
merged 8 commits into from Nov 15, 2019
Merged

Strip JSON #9

merged 8 commits into from Nov 15, 2019

Conversation

@zwilias
Copy link
Owner

zwilias commented Oct 17, 2019

stripString and stripValue allow - given a decoder - to transform JSON to the bare minimum of what is required to make the decoder succeed.

Needs:

  • docs
  • more thinking about edge cases and tests for them

In particular, I'm worried about combinations of oneOf and andThen. I have a slight hunch that it might actually be impossible to make this consistently correct. I also hope I turn out to be wrong.

zwilias and others added 8 commits Oct 17, 2019
Also figured out that for `index`, we need to mark all lower indexes as having
been ascertained. I think this makes sense!
We're kind of cheating a tiny bit, but I think that's fine.
* Add verify-example for stripString function.

* Add a test case using andThen on a List to count length.

* Update stripValue docs.
I have issues.
@zwilias zwilias merged commit e2b62df into master Nov 15, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@zwilias zwilias deleted the feature/relevant-json branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.