Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve selection support #23

Closed
5 tasks done
akissinger opened this issue May 23, 2023 · 3 comments
Closed
5 tasks done

Improve selection support #23

akissinger opened this issue May 23, 2023 · 3 comments
Labels
Type: code organisation and standards Issue deals with how the code is structured or written Type: enhancement New feature or request

Comments

@akissinger
Copy link
Member

akissinger commented May 23, 2023

Currently selection behaviour is a bit shonky. I suggest we:

@akissinger akissinger mentioned this issue May 23, 2023
3 tasks
@jvdwetering jvdwetering added Type: enhancement New feature or request Type: code organisation and standards Issue deals with how the code is structured or written labels Jun 6, 2023
@jvdwetering
Copy link
Collaborator

Many things here fixed by PR #37

@jvdwetering
Copy link
Collaborator

Rectangular selection is now supported, but shift-clicking is not. The Qt default is control-clicking. It is probably not too difficult to also allow shift-clicking.
I'm not sure what exactly you mean by preserving selection state across undo/redo. That you automatically support the part of the graph that was reverted back by the undo? Or that changes of selection also go on the undo stack? Or that an undo remembers what the state was of the selection at the moment the action of the undo happened, and then when you undo it reverts back to this selection state?

@RazinShaikh
Copy link
Collaborator

I am closing this collection as we have a decent support for selection now and the last remaining point "maintain selection state across undo/redo" can be tracked in its own issue at #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: code organisation and standards Issue deals with how the code is structured or written Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants