Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WifiResultParser overloads H: for "hidden", "phase 2 method" #1254

Closed
srowen opened this issue Jan 27, 2020 · 1 comment
Closed

WifiResultParser overloads H: for "hidden", "phase 2 method" #1254

srowen opened this issue Jan 27, 2020 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@srowen
Copy link
Contributor

@srowen srowen commented Jan 27, 2020

(Reported by Albert Sanz via email.)

In https://github.com/zxing/zxing/blob/master/core/src/main/java/com/google/zxing/client/result/WifiResultParser.java#L60 , we see that H: is used as the prefix for 'hidden', but, also used for 'phase 2 method'. This can't be right.

This was ultimately because of my own error in reviewing a change 2 years ago:
#865 (comment)

Instead I think we can use the originally proposed PH2: for phase 2 method.

In order to try to retain compatibility, the code can interpret H: as 'hidden' if it is 'true' or 'false', or if PH2: was set separately. Otherwise, interpret it as phase 2 method. This shouldn't break any existing usage.

@srowen srowen added the bug label Jan 27, 2020
@srowen srowen added this to the 3.4.1 milestone Jan 27, 2020
@srowen srowen self-assigned this Jan 27, 2020
srowen added a commit that referenced this issue Jan 27, 2020
@srowen

This comment has been minimized.

Copy link
Contributor Author

@srowen srowen commented Jan 27, 2020

Resolved in 2e2b5ba

@srowen srowen closed this Jan 27, 2020
holylance added a commit to holylance/zxing that referenced this issue Jan 29, 2020
Resolve issue zxing#1254: overloaded H: for hidden/p2m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.