New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataMatrix encoder broken for certain short EDIFACT messages #908

Closed
axxel opened this Issue Nov 14, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@axxel

axxel commented Nov 14, 2017

I'm helping out at a new C++ port of this code base (https://github.com/nu-book/zxing-cpp). I stumbled on an issue with messages encoded with EDIFACT that need 2 code words padding. During debugging and research I found out that this issue has been discovered "upstream" over 5 years ago: https://sourceforge.net/p/barcode4j/bugs/38/.

Steps to reproduce: create a DataMatrix with the message <ABCDEFG><ABCDEFGK> -> the resulting image contains an invalid code.

I don't have a pull request but the fix is just one line, see here.

@srowen srowen added the bug label Nov 14, 2017

@srowen srowen added this to the 3.4.0 milestone Nov 14, 2017

@srowen srowen self-assigned this Nov 14, 2017

srowen added a commit that referenced this issue Nov 14, 2017

@srowen

This comment has been minimized.

Show comment
Hide comment
@srowen

srowen Nov 14, 2017

Contributor

Sounds good, fixed.

Contributor

srowen commented Nov 14, 2017

Sounds good, fixed.

@srowen srowen closed this Nov 14, 2017

@srowen srowen modified the milestones: 3.4.0, 3.3.2 Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment