New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite DataMatrix Detector #1080

Merged
merged 5 commits into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@makiuchi-d
Contributor

makiuchi-d commented Oct 4, 2018

In DataMatrixBlackBox2TestCase, only 8 of 18 images can read without rotation.
So I rewrote the detector and got better score.

Main idea of this PR is moving the corner points to near the center of the corner modules
because detecting transitions on the edge is not stable.

@srowen

srowen approved these changes Oct 4, 2018

Hm! yeah that's a nice win. I haven't reviewed every line of the change but I see it's mostly a reorg and logic change along the lines you say. I don't see any downside, as it's also less complex.

@srowen srowen merged commit c13216c into zxing:master Oct 4, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details

@makiuchi-d makiuchi-d deleted the makiuchi-d:rewrite-datamatrix-detector branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment