requireSpaceBeforeKeywords: hotfix for predefined list of keywords

Fixes jscs-dev#2135
qfox · Feb 15, 2016 · 381496f · 381496f
1 parent c695048
commit 381496f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/rules/require-space-before-keywords.js b/lib/rules/require-space-before-keywords.js
@@ -55,7 +55,7 @@ module.exports.prototype = {
             excludedKeywords = keywords.allExcept;
         }
 
-        keywords = defaultKeywords.filter(function(keyword) {
+        keywords = (keywords === true ? defaultKeywords : keywords).filter(function(keyword) {
             return (excludedKeywords.indexOf(keyword) === -1);
         });
 

diff --git a/test/specs/rules/require-space-before-keywords.js b/test/specs/rules/require-space-before-keywords.js
@@ -121,4 +121,14 @@ describe('rules/require-space-before-keywords', function() {
         expect(errors).to.have.one.validation.error.from('requireSpaceBeforeKeywords');
         expect(errors.explainError(error)).to.have.string('Missing space before "function" keyword');
     });
+
+    it('should not report keyword not in list #2135', function() {
+        checker.configure({ requireSpaceBeforeKeywords: ['nottypeof'] })
+
+        expect(checker.checkString(
+            'module.exports = function() {\n' +
+            '  if (typeof value !== \'function\') { return false; }\n' +
+            '};\n'
+        )).to.have.no.errors()
+    });
 });