Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add terminal awareness ingredient. #15
Conversation
kissiel
commented
Sep 5, 2015
|
Gnome terminal issue was traced to localized output of --version. This is now fixed. |
|
It would help if someone could tell me how to identify powershell though. We could at least say everything is unsupported for now. |
stuartlangridge
commented
Sep 6, 2015
|
@stuartlangridge yes that is expected. With all kinds of remote connections (I didn't test mosh yet, actually, mmm) we cannot know what the host is doing and what is really supports. It might be ssh from linux console or from windows xp, it might be gnome-terminal on latest version of gnome. Those differ entirely and there's no way to say. In a follow-up from this I will prepare patches for most important terminals to set TERM_PROGRAM and TERM_PROGRAM_VERSION and for ssh to forward those across. This would allow guacamole to know what is on the other side but it's a long process and I'm not sure if upstreams will want to accept my patches. |
zyga
added some commits
Sep 6, 2015
|
OS X needs process tree traversal to understand screen and tmux correctly. |
hrw
commented
Sep 6, 2015
hrw
commented
Sep 6, 2015
|
@hrw Thanks for checking. I'll add support for XFCE. I was quite surprised that xterm started from konsole was mis-identified though. I will look into that. Thanks again :) |
hrw
commented
Sep 6, 2015
|
Uuuuh, I wasn't expecting a crasher! Damn, looking now. |
hrw
commented
Sep 6, 2015
hrw
commented
Sep 6, 2015
|
I've pushed a fix for version. Can you re-run it where it used to crash? That will help me fix everything and get the profiles right. |
|
@hrw In XTerm 319, was blinking working? It looks like older xterm was supporting dim (for me it worked on 312) but it stopped to work on 319. |
hrw
commented
Sep 6, 2015
|
Wow, this is the first time I've seen both blinks to work! Fantastic. Can you help me with one more thing: for unknown terminals please tell me what the executable is called and what the output of the --version (or similar) command is. I specifically need to know the executable name and how to check for its version string. |
hrw
commented
Sep 6, 2015
hrw
commented
Sep 6, 2015
|
00:06 hrw@puchatek:guacamole$ xfce4-terminal --version Copyright (c) 2003-2012 Autor: Benedikt Meurer benny@xfce.org Proszę zgłaszać błędy na adres http://bugzilla.xfce.org/. |
hrw
commented
Sep 6, 2015
|
00:08 hrw@puchatek:guacamole$ urxvt -version |
zyga
added some commits
Sep 6, 2015
|
@hrw XFCE4 Terminal should work now |
hrw
commented
Sep 6, 2015
|
Detected Terminal: XFCE4 Terminal, version 0.6.3 |
|
Fantastic, thanks! Can you confirm that urxvt -help prints the version number? |
hrw
commented
Sep 6, 2015
|
It does. On stderr. |
|
Can you re-run with urxvt and just check if anything is mis-detected now. (No need for more screenshots) |






















zyga commentedSep 5, 2015
This rather huge patch adds the terminal awareness ingredient. This
ingredient implements terminal emulator fingerprinting coupled with a
look-aside table of features and their implementation status for each of
the multiple supported terminal emulator programs.
Extensive care was taken to support virtually everything that is
actually used out there in the field.
The list of detected, mainstream terminals includes:
The list of niche terminals also supported includes:
In addition the following terminal multiplexers are supported:
Lastly all remote terminals connected over SSH are identified as such
but the true nature of the terminal is not known.
This patch also contains an interesting example, examples/terminal.py.
Running this program with the "check" subcommand will create a visual
"test case" that shows all the information that guacamole managed to
find out along with a breakdown for all of the features and their
status. This can be used to validate if something works as expected.
Unfortunately it is a out-of-band knowledge so it will have to be
updated over time.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com