Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Refresh patches for snapd spec #10
Conversation
| @@ -187,15 +192,18 @@ install -p -m 0755 bin/snap %{buildroot}%{_bindir} | ||
| install -p -m 0755 bin/snap-exec %{buildroot}%{_libexecdir}/snapd | ||
| install -p -m 0755 bin/snapd %{buildroot}%{_libexecdir}/snapd | ||
| +# Install snap(8) man page | ||
| +bin/snap help --man > %{buildroot}%{_mandir}/man8/snap.8 |
| +install -p -m 0644 dist/snapd.service %{buildroot}%{_unitdir} | ||
| +install -p -m 0644 dist/snapd.autoimport.service %{buildroot}%{_unitdir} | ||
| +install -p -m 0644 dist/snapd.refresh.service %{buildroot}%{_unitdir} | ||
| +install -p -m 0644 dist/snapd.refresh.timer %{buildroot}%{_unitdir} |
zyga
Oct 30, 2016
Owner
I like the dist/ directory. When packaging moves elsewhere (maybe this week but doubtful we'll finish) it will be a nice place to keep the services around.
| -install -p -m 0644 debian/snapd.frameworks-pre.target %{buildroot}%{_unitdir} | ||
| -install -p -m 0644 debian/snapd.frameworks.target %{buildroot}%{_unitdir} | ||
| +# Install udev rules (must run before udisks2) | ||
| +install -p -m 0644 debian/snapd.autoimport.udev %{buildroot}%{_udevrulesdir}/66-snapd-autoimport.rules |
zyga
Oct 30, 2016
Owner
We might not need any of the auto import bits. I'm checking with other team members to be certain.
zyga
approved these changes
Oct 30, 2016
Everything looks good. If we need to remove auto import I'll follow up with a small branch.
zyga
merged commit d057009
into
zyga:master
Oct 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Conan-Kudo commentedOct 28, 2016
No description provided.