Change variable name basedir to base_dir #32

Merged
merged 1 commit into from Jun 25, 2012

9 participants

@vijaydev

basedir was changed to base_dir in 849df5e#L5L132

@fxn

This bug prevents the Rails edge API from being generated. No rush, just for the record.

@drbrain

Ugh, my bad, I'm sorry ☹

@fxn

Hi! Just a ping in case this can be applied.

@fxn

@voloko it would be really helpful to get this PR applied and a new gem released if you had a minute. The API of the current Rails stable release can't be generated, which is more worrying than having the edge API temporarily frozen.

@zhengjia

rake rdoc failed
+1 to pull it in

@ndbroadbent
Collaborator

+1, I'm also getting this error.

undefined local variable or method `basedir' for #<RDoc::Generator::SDoc:0x953eeb4>
@fxn fxn added a commit to fxn/sdoc that referenced this pull request Dec 8, 2011
@fxn fxn applies Vijay's patch in #32 of voloko's repo 055fe2a
@navditt

Just as fxn say 7 months ago, this bug prevents the Rails API from being generated.

@joneslee85

+1 please merge

@voloko voloko merged commit ff80cbe into zzak:master Jun 25, 2012
@voloko
Collaborator

I'm very sorry for not supporting the project for so long. Does anyone of you feel like supporting it? Both the site and the github repo? I'll very much appreciate it. Email me at voloko@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment