From 7446d0fc4e80a2cacdf91cbb47795bc8e6829f01 Mon Sep 17 00:00:00 2001
From: Milana <milanazzap@gmail.com>
Date: Wed, 3 Nov 2021 12:44:02 +0100
Subject: [PATCH 1/5] Block class - render_callback() improvements.

---
 php/Block.php | 95 ++++++++++++++++++++++++++++++---------------------
 1 file changed, 57 insertions(+), 38 deletions(-)

diff --git a/php/Block.php b/php/Block.php
index 0d1d2a6..595777e 100644
--- a/php/Block.php
+++ b/php/Block.php
@@ -63,37 +63,60 @@ public function register_block() {
 	 * @return string The markup of the block.
 	 */
 	public function render_callback( $attributes, $content, $block ) {
-		$post_types = get_post_types(  [ 'public' => true ] );
-		$class_name = $attributes['className'];
-		ob_start();
+		$class_name = '';
+		$post_types = get_post_types( array( 'public' => true ) );
+		if ( isset( $attributes['className'] ) && ! empty( $attributes['className'] ) ) :
+			$class_name = $attributes['className'];
+		endif;
 
+		ob_start();
 		?>
-        <div class="<?php echo $class_name; ?>">
-			<h2>Post Counts</h2>
+		<div <?php echo $class_name ? 'class="' . esc_attr( $class_name ) . '"' : ''; ?>>
+			<h2><?php esc_html_e( 'Post Counts', 'site-counts' ); ?></h2>
+			<?php if ( is_array( $post_types ) ) : ?>
 			<ul>
 			<?php
 			foreach ( $post_types as $post_type_slug ) :
-                $post_type_object = get_post_type_object( $post_type_slug  );
-                $post_count = count(
-                    get_posts(
-						[
-							'post_type' => $post_type_slug,
-							'posts_per_page' => -1,
-						]
-					)
-                );
+				$post_type_object  = get_post_type_object( $post_type_slug  );
+				$post_count_object = wp_count_posts( $post_type_slug );
 
+				if ( 'attachment' === $post_type_slug ) :
+					$post_count = $post_count_object->inherit;
+				else :
+					$post_count = $post_count_object->publish;
+				endif;
 				?>
-				<li><?php echo 'There are ' . $post_count . ' ' .
-					  $post_type_object->labels->name . '.'; ?></li>
-			<?php endforeach;	?>
-			</ul><p><?php echo 'The current post ID is ' . $_GET['post_id'] . '.'; ?></p>
+				<li>
+				<?php
+				printf(
+					/* translators: %1$s: Post count number, %2$s: Post type singular name, %3$s: Post type plural name. */
+					esc_html( _nx( 'There is %1$s %2$s.', 'There are %1$s %3$s.', $post_count, 'Post Count List Item', 'site-counts' ) ),
+					esc_html( number_format_i18n( $post_count ) ),
+					$post_type_object->labels->singular_name,
+					$post_type_object->labels->name
+				);
+				?>
+				</li>
+			<?php endforeach; // $post_types as $post_type_slug ?>
+			</ul>
+			<?php endif; // is_array( $post_types ) ?>
+
+			<p>
+			<?php printf(
+				/* translators: %s: Current Post ID. */
+				esc_html__( 'The current post ID is %s.', 'site-counts' ),  get_the_ID()
+			); ?>
+			</p>
 
 			<?php
-			$query = new WP_Query(  array(
-				'post_type' => ['post', 'page'],
-				'post_status' => 'any',
-				'date_query' => array(
+			$query = new WP_Query( array(
+				'post_type'      => array( 'post', 'page' ),
+				'posts_per_page' => 5,
+				'post_status'    => 'any',
+				'tag'            => 'foo',
+				'category_name'  => 'baz',
+				'post__not_in'   => array( get_the_ID() ),
+				'date_query'     => array(
 					array(
 						'hour'      => 9,
 						'compare'   => '>=',
@@ -103,24 +126,20 @@ public function render_callback( $attributes, $content, $block ) {
 						'compare'=> '<=',
 					),
 				),
-                'tag'  => 'foo',
-                'category_name'  => 'baz',
-				  'post__not_in' => [ get_the_ID() ],
-				  'meta_value' => 'Accepted',
-			));
+			) );
 
-			if ( $query->found_posts ) :
+			if ( $query->have_posts() ) :
+			?>
+				<h2><?php esc_html_e( 'Any 5 posts with the tag of foo and the category of baz', 'site-counts' ); ?></h2>
+				<ul>
+				<?php
+				while ( $query->have_posts() ) : $query->the_post();
+					the_title( '<li>', '</li>' );
+				endwhile;
+				wp_reset_postdata();
 				?>
-				 <h2>Any 5 posts with the tag of foo and the category of baz</h2>
-                <ul>
-                <?php
-
-                 foreach ( array_slice( $query->posts, 0, 5 ) as $post ) :
-                    ?><li><?php echo $post->post_title ?></li><?php
-				endforeach;
-			endif;
-		 	?>
-			</ul>
+				</ul>
+			<?php endif; // $query->have_posts() ?>
 		</div>
 		<?php
 

From 7bfce60e8ad1f9d9d5d246e9a5c4838c29bb6904 Mon Sep 17 00:00:00 2001
From: Milana <milanazzap@gmail.com>
Date: Wed, 3 Nov 2021 16:54:57 +0100
Subject: [PATCH 2/5] Block class - render_callback() query optimisation.

---
 php/Block.php | 29 ++++++++++++++++++++---------
 1 file changed, 20 insertions(+), 9 deletions(-)

diff --git a/php/Block.php b/php/Block.php
index 595777e..e8ce17b 100644
--- a/php/Block.php
+++ b/php/Block.php
@@ -63,6 +63,7 @@ public function register_block() {
 	 * @return string The markup of the block.
 	 */
 	public function render_callback( $attributes, $content, $block ) {
+		$exclude = array( get_the_ID() );
 		$class_name = '';
 		$post_types = get_post_types( array( 'public' => true ) );
 		if ( isset( $attributes['className'] ) && ! empty( $attributes['className'] ) ) :
@@ -110,13 +111,14 @@ public function render_callback( $attributes, $content, $block ) {
 
 			<?php
 			$query = new WP_Query( array(
-				'post_type'      => array( 'post', 'page' ),
-				'posts_per_page' => 5,
-				'post_status'    => 'any',
-				'tag'            => 'foo',
-				'category_name'  => 'baz',
-				'post__not_in'   => array( get_the_ID() ),
-				'date_query'     => array(
+				'post_type'              => array( 'post', 'page' ),
+				'posts_per_page'         => 10,
+				'post_status'            => 'any',
+				'no_found_rows'          => true,
+				'update_post_meta_cache' => false,
+				'update_post_term_cache' => false,
+				'fields'                 => 'ids',
+				'date_query'             => array(
 					array(
 						'hour'      => 9,
 						'compare'   => '>=',
@@ -133,8 +135,17 @@ public function render_callback( $attributes, $content, $block ) {
 				<h2><?php esc_html_e( 'Any 5 posts with the tag of foo and the category of baz', 'site-counts' ); ?></h2>
 				<ul>
 				<?php
-				while ( $query->have_posts() ) : $query->the_post();
-					the_title( '<li>', '</li>' );
+				$posts = 0;
+				while ( $query->have_posts() && $posts < 5 ) :
+					$query->the_post();
+					$current = get_the_ID();
+					if ( in_array( $current, $exclude ) ) {
+						continue;
+					}
+					if ( has_tag( 'foo', $current ) && has_category( 'baz', $current ) ) :
+						$posts++;
+						the_title( '<li>', '</li>' );
+					endif;
 				endwhile;
 				wp_reset_postdata();
 				?>

From 6543d164794f94d4142f29f99c2a444267d6c101 Mon Sep 17 00:00:00 2001
From: Milana <milanazzap@gmail.com>
Date: Wed, 3 Nov 2021 17:02:08 +0100
Subject: [PATCH 3/5] Block class - render_callback() query optimisation.

---
 php/Block.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/php/Block.php b/php/Block.php
index e8ce17b..db8d2b7 100644
--- a/php/Block.php
+++ b/php/Block.php
@@ -112,7 +112,7 @@ public function render_callback( $attributes, $content, $block ) {
 			<?php
 			$query = new WP_Query( array(
 				'post_type'              => array( 'post', 'page' ),
-				'posts_per_page'         => 10,
+				'posts_per_page'         => 5 + count( $exclude ),
 				'post_status'            => 'any',
 				'no_found_rows'          => true,
 				'update_post_meta_cache' => false,

From 9969d121f335d68491bd0404384250ae3938a7c9 Mon Sep 17 00:00:00 2001
From: Milana <milanazzap@gmail.com>
Date: Wed, 3 Nov 2021 17:05:17 +0100
Subject: [PATCH 4/5] Block class - render_callback() query optimisation.

---
 php/Block.php | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/php/Block.php b/php/Block.php
index db8d2b7..110a4c9 100644
--- a/php/Block.php
+++ b/php/Block.php
@@ -135,15 +135,13 @@ public function render_callback( $attributes, $content, $block ) {
 				<h2><?php esc_html_e( 'Any 5 posts with the tag of foo and the category of baz', 'site-counts' ); ?></h2>
 				<ul>
 				<?php
-				$posts = 0;
-				while ( $query->have_posts() && $posts < 5 ) :
+				while ( $query->have_posts() ) :
 					$query->the_post();
 					$current = get_the_ID();
 					if ( in_array( $current, $exclude ) ) {
 						continue;
 					}
 					if ( has_tag( 'foo', $current ) && has_category( 'baz', $current ) ) :
-						$posts++;
 						the_title( '<li>', '</li>' );
 					endif;
 				endwhile;

From 529f0c0ca30d9403bc86efc59f17d136c516ad63 Mon Sep 17 00:00:00 2001
From: Milana <milanazzap@gmail.com>
Date: Wed, 3 Nov 2021 17:09:25 +0100
Subject: [PATCH 5/5] Block class - render_callback() query optimisation.

---
 php/Block.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/php/Block.php b/php/Block.php
index 110a4c9..4f449c4 100644
--- a/php/Block.php
+++ b/php/Block.php
@@ -138,7 +138,7 @@ public function render_callback( $attributes, $content, $block ) {
 				while ( $query->have_posts() ) :
 					$query->the_post();
 					$current = get_the_ID();
-					if ( in_array( $current, $exclude ) ) {
+					if ( in_array( $current, $exclude, true ) ) {
 						continue;
 					}
 					if ( has_tag( 'foo', $current ) && has_category( 'baz', $current ) ) :