Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Feb 16, 2013
  1. @edwardcapriolo
  2. @edwardcapriolo
  3. @edwardcapriolo

    More perf tests

    edwardcapriolo authored
Commits on Feb 15, 2013
  1. @edwardcapriolo

    Merge pull request #94 from zznate/preparedcleanup

    edwardcapriolo authored
    Minor cleanup on prepared statement
  2. @edwardcapriolo
  3. @edwardcapriolo

    Minor cleanup

    edwardcapriolo authored
  4. @edwardcapriolo
  5. @edwardcapriolo
  6. @edwardcapriolo
Commits on Feb 12, 2013
  1. @edwardcapriolo

    Minor bug

    edwardcapriolo authored
  2. @edwardcapriolo

    Merge pull request #93 from jsanda/filter-lang-support

    edwardcapriolo authored
    Refactor CREATEFILTER and add additional language support
  3. @jsanda

    encapsulate filter factory logic in FactoryProvider

    jsanda authored
    The work of determing which factory to use is now delegated to
    FactoryProvider, which could be extended with similar logic for creating
    processors.
Commits on Feb 11, 2013
  1. @jsanda

    adding initial support for javascript filters

    jsanda authored
    This is a bit different from how groovy is supported. For a JavaScript filter
    you have to specify a single function as follows,
    
    function over21(row] { if (row['value'] > 21) return row else return null; }
    
    With the groovy implementation changes I made in 47737c4 you can define an
    entire script, and the return value is assumed to be the filter. The JavaScript
    version is different because the ECMA spec considers it illegal to have a
    return statement outside of a function. But similar to a groovy script, the last
    line of a javascript script is the return value of the script; so, it might be
    possible to make behavior more consistent. For now though I am inclined to
    leave it as is until I see how things look for other languages.
    
    The other thing to point out with this commit is some of the work done in
    JavaScriptFilter. A java.util.Map passed into a script is not treated as native
    javascript object; so I first convert the row method argument into a
    javascript object that is then passed to the function. JavaScript objects do
    however implement Map so there is no conversion required for the return value
    from the script function.
    
    Lastly, integration tests have been updated as well.
Commits on Feb 10, 2013
  1. @jsanda

    refactoring groovy filter support

    jsanda authored
    The client can now provide a groovy filter that is either a closure or is a
    direct implementation of Filter. The former can be as simple as,
    
    // simple closure filter
    { row -> if (row['value'].toInteger() > 21) return row else return null }
    
    and the latter might look like,
    
    // filter that directly implements Filter
    class Over21 implements Filter {
      Map filter(Map row) {
        if (row['value'].toInteger() > 21) {
          return row
        } else {
          return null
        }
      }
    }
    
    GroovyFilterFactory encapsulate the logic for creating a groovy filter. If the
    client script returns a closure, then the factory will wrap it in a
    GroovyFilter. If the script returns an instance of Filter than that object
    itself is returned. If the script returns neither a closure nor a filter, then
    the factory throws an exception. In subsequent commits I will provide similar
    logic for other languages.
  2. Merge pull request #91 from zznate/ic2

    authored
    Ic2
Commits on Feb 9, 2013
  1. @edwardcapriolo

    Woo hoo

    edwardcapriolo authored
  2. @jsanda
  3. @edwardcapriolo
Commits on Feb 8, 2013
  1. @edwardcapriolo
  2. @edwardcapriolo

    Dont forget

    edwardcapriolo authored
  3. @edwardcapriolo
  4. @edwardcapriolo
  5. @edwardcapriolo
  6. Merge pull request #84 from jsanda/getref-refactor

    authored
    refactoring to replace GETREF IntraOp with a map
  7. @jsanda

    refactoring to replace GETREF IntraOp with a map

    jsanda authored
    This change is a result of the discussion in
    #80. The GETREF IntraOp has been
    removed with this commit. Its intended use was as the value of a SET IntraOp.
    I already added logic in IntraService to handle a nested map in a SET command
    since we do not have Jackson configured to deserialize a nested IntraOp.
    IntraServiceITest has been refactored to use a nested map where GETREF was
    previously used.
  8. @edwardcapriolo
  9. @edwardcapriolo

    TODOs for future stuff

    edwardcapriolo authored
Commits on Feb 7, 2013
  1. @edwardcapriolo

    Merge pull request #80 from jsanda/json-itests

    edwardcapriolo authored
    Adding integration tests for GETREF and SLICE over JSON.
  2. @jsanda

    Adding integration tests for GETREF and SLICE over JSON.

    jsanda authored
    This commit also includes a change to IntraService. The SET op typically looks
    like,
    
    {
      "type": "SET",
      "op": {
        "rowkey": "row_key1",
        "name": "column1",
        "value": "value1"
      }
    }
    
    but when using GETREF it looks like,
    
    {
      "type": "SET",
      "op": {
        "rowkey": "getref_test",
        "name": "col3",
        "value": {
          "type": "GETREF",
          "op": {
            "resultref": 4,
            "wanted": "value"
          }
        }
      }
    }
    
    In this case the value attribute references a nested GETREF op. With the
    default JSON deserialization, the nested GETREF is getted deserialized as a
    Map instead of a IntraOp. I have added logic in InstraService to handle the
    nested map.
  3. @edwardcapriolo @jsanda
  4. @edwardcapriolo @jsanda

    White space

    edwardcapriolo authored jsanda committed
  5. @edwardcapriolo @jsanda

    Test coverage of the spify new timeout feature.

    edwardcapriolo authored jsanda committed
  6. @edwardcapriolo @jsanda

    Timeout ops

    edwardcapriolo authored jsanda committed
  7. Merge pull request #81 from zznate/timeout

    authored
    Timeout
  8. Merge pull request #79 from zznate/timeout

    authored
    Timeout ops
Something went wrong with that request. Please try again.