Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Move refactor IntraHandlerJson to extend IntraHandlerBase #142

Closed
zznate opened this Issue · 6 comments

2 participants

@zznate
Owner

This involves several parts:

  • moving IntraHandlerJson into handler.http.payload package
  • moving new IntraHandlerRest into handler.http.rest package
  • moving up the functionality as needed for IntraHandlerJson to be in the new IntraHandler hierarchy
  • changing the bus names to be more reflective of this split. eg.: "request." gets changed to "http.payload." and we introduce a "http.rest.*"

This last part gives us a cleaner uniformity to bus identifiers and package names which just feels like good practice to me.

@edwardcapriolo
Collaborator

Realted question.

logger.debug("Starting IntravertCassandraServer...");
vertx = Vertx.newVertx();
rm = new RouteMatcher();
rm.put("/:appid/hello", new HelloHandler());
rm.get("/:appid/hello", new HelloHandler());
rm.post("/:appid/hello", new HelloHandler());
rm.post("/:appid/intrareq-json", new IntraHandlerJson(vertx));
rm.post("/:appid/intrareq-jsonsmile", new IntraHandlerJsonSmile(vertx));

I copied the appid convention from the original script what is this? why are we doing this ? should we change this?

@edwardcapriolo
Collaborator

Also we may want to take care of versioning here. For both the html endpoints and the handler names. If we make breaking changes we should bump versions and consider supporting old code for at least 2 majors.

@zznate
Owner

I will take 'appid' out with this issue as well. This was from the original usergrid use case. I'll have this one cleaned up today.
Agreed on the versioning. But that is more sophisticated than it seems (the way I want to do it - both pragamatically and rest-full-y) that I'll open another ticket.

@zznate
Owner

Added #148 for tracking versioning.

@zznate
Owner

Created #157 for tracking removal of appid

@edwardcapriolo
Collaborator

Are we done here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.