make HandlerUtils.readCf create and return a JsonArray of columns #116

Merged
merged 1 commit into from Feb 26, 2013

Conversation

Projects
None yet
2 participants
Collaborator

jsanda commented Feb 26, 2013

While I was looking at something else, I noticed that the callers of
HandlerUtils.readCf both take the list of maps that gets populated, iterates
through the list, converts each map to a JsonObject, and then adds that object
to a JsonArray that is sent back in the response to the reply handler.

This commit removes that duplicate work and also eliminates the extra work of
looping over all of the columns again. This change will also help with some stuff I am looking to do for issue #115.

@jsanda jsanda make HandlerUtils.readCf create and return a JsonArray of columns
While I was looking at something else, I noticed that the callers of
HandlerUtils.readCf both take the list of maps that gets populated, iterates
through the list, converts each map to a JsonObject, and then adds that object
to a JsonArray that is sent back in the response to the reply handler.

This commit removes that duplicate work and also eliminates the extra work of
looping over all of the columns again.
f483a34

@zznate zznate added a commit that referenced this pull request Feb 26, 2013

@zznate zznate Merge pull request #116 from jsanda/refactor-readCf
make HandlerUtils.readCf create and return a JsonArray of columns
209b4cc

@zznate zznate merged commit 209b4cc into zznate:master Feb 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment