Counters are now properly treated as longs #185

merged 1 commit into from Apr 10, 2013


None yet
2 participants

edwardcapriolo commented Apr 10, 2013

So Jackson/vertx/us is doing something fishy with long -> int conversions. It is rather annoying that get_count can return int or long depending on the size. However this patch allows us to treat coutners as long, maybe as a follow on we can come up with a way for them to always return a long. For now the client simply has to be aware that if the counter < Integer.Max_value intravert will return an integer.

zznate added a commit that referenced this pull request Apr 10, 2013

Merge pull request #185 from zznate/counters_fix_for_long
Counters are now properly treated as longs

@zznate zznate merged commit 4befa65 into master Apr 10, 2013

@zznate zznate deleted the counters_fix_for_long branch Apr 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment