Fix TypeError for class_mapper called w/ iterable #58

Merged
merged 1 commit into from Jan 15, 2014

Projects

None yet

2 participants

@kstark

When the class_ passed is not a mapped class but is actually an iterable, the string formatting operation fails with a TypeError: not all arguments converted exception, and the expected ArgumentError is not raised. Calling code which is using reflection and expects this error will fail (e.g. the sadisplay module).

@kstark kstark Fix TypeError for class_mapper called w/ iterable
When the class_ passed is not a mapped class but is actually an iterable, the string formatting operation fails with a TypeError, and the expected ArgumentError is not raised. Calling code which is using reflection and expects this error will fail (e.g. the sadisplay module).
58d3a41
@zzzeek zzzeek merged commit d87923c into zzzeek:master Jan 15, 2014
@zzzeek
Owner

thanks!

@zzzeek
Owner

changelog + test in 789ab91, cherry pick to 0.8 in 26b899e, aace3b0

@kstark kstark deleted the unknown repository branch Jan 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment