Wrong type usage in StringTest #95

Merged
merged 1 commit into from Jun 8, 2014

Conversation

Projects
None yet
2 participants
@BY-jk
Contributor

BY-jk commented May 30, 2014

The StringTest.test_literal_backslashes() method makes use of Type 'Text' instead of 'String'. This causes the test suite to fail for dialects that support String but not Text.

Wrong type usage
Wrong Type (TEXT) being used in StringTest
@BY-jk

This comment has been minimized.

Show comment Hide comment
@BY-jk

BY-jk Jun 3, 2014

Contributor

Any chance that this minimal change will make it into the next release? It breaks our build for the EXASOL dialect as it does not support the TEXT type. Deactivating the String Tests would be a suboptimal solution.

Contributor

BY-jk commented Jun 3, 2014

Any chance that this minimal change will make it into the next release? It breaks our build for the EXASOL dialect as it does not support the TEXT type. Deactivating the String Tests would be a suboptimal solution.

@zzzeek

This comment has been minimized.

Show comment Hide comment
@zzzeek

zzzeek Jun 4, 2014

Owner

yes this pullreq is marked with the purple marker, means its on my list as I get a chance to review and merge PRs

Owner

zzzeek commented Jun 4, 2014

yes this pullreq is marked with the purple marker, means its on my list as I get a chance to review and merge PRs

@zzzeek zzzeek merged commit 39bea64 into zzzeek:master Jun 8, 2014

@zzzeek

This comment has been minimized.

Show comment Hide comment
@zzzeek

zzzeek Jun 8, 2014

Owner

thanks! merged to 0.9 as well

Owner

zzzeek commented Jun 8, 2014

thanks! merged to 0.9 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment