Wrong type usage in StringTest #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong Type (TEXT) being used in StringTest
This was referenced May 30, 2014
|
Any chance that this minimal change will make it into the next release? It breaks our build for the EXASOL dialect as it does not support the TEXT type. Deactivating the String Tests would be a suboptimal solution. |
|
yes this pullreq is marked with the purple marker, means its on my list as I get a chance to review and merge PRs |
|
thanks! merged to 0.9 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StringTest.test_literal_backslashes() method makes use of Type 'Text' instead of 'String'. This causes the test suite to fail for dialects that support String but not Text.