New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it support .net core ?? #13

Closed
tavisca-arvindy opened this Issue Jun 5, 2017 · 12 comments

Comments

Projects
None yet
3 participants
@tavisca-arvindy

tavisca-arvindy commented Jun 5, 2017

No description provided.

@JonathanMagnan JonathanMagnan self-assigned this Jun 5, 2017

@JonathanMagnan

This comment has been minimized.

Show comment
Hide comment
@JonathanMagnan

JonathanMagnan Jun 5, 2017

Member

Hello @tavisca-arvindy ,

Since the v1.5.0, the library support .NET Core for NETSTANDARD 1.6

Let me know if that answer correctly to your question.

Best Regards,

Jonathan

Member

JonathanMagnan commented Jun 5, 2017

Hello @tavisca-arvindy ,

Since the v1.5.0, the library support .NET Core for NETSTANDARD 1.6

Let me know if that answer correctly to your question.

Best Regards,

Jonathan

@pendenaor

This comment has been minimized.

Show comment
Hide comment
@pendenaor

pendenaor Jun 6, 2017

Hi,
The nuget seems broken, it targets netcore 4.5, which does not exist.

pendenaor commented Jun 6, 2017

Hi,
The nuget seems broken, it targets netcore 4.5, which does not exist.

@pendenaor

This comment has been minimized.

Show comment
Hide comment
@pendenaor

pendenaor Jun 6, 2017

May i ask you if NetStandard 1.6 is truly needed ?

pendenaor commented Jun 6, 2017

May i ask you if NetStandard 1.6 is truly needed ?

@JonathanMagnan

This comment has been minimized.

Show comment
Hide comment
@JonathanMagnan

JonathanMagnan Jun 6, 2017

Member

it targets netcore 4.5, which does not exist.

That was for Metro application which supports .NET "Core" 4.5 (Target Windows 8)

It was before the .NET Core we know today.

May i ask you if NetStandard 1.6 is truly needed?

It's for sure needed. That's the version that is used with .NET Core

Or perhaps I misunderstood your question?

Best Regards,

Jonathan

Member

JonathanMagnan commented Jun 6, 2017

it targets netcore 4.5, which does not exist.

That was for Metro application which supports .NET "Core" 4.5 (Target Windows 8)

It was before the .NET Core we know today.

May i ask you if NetStandard 1.6 is truly needed?

It's for sure needed. That's the version that is used with .NET Core

Or perhaps I misunderstood your question?

Best Regards,

Jonathan

@pendenaor

This comment has been minimized.

Show comment
Hide comment
@pendenaor

pendenaor Jun 6, 2017

May i ask you if NetStandard 1.6 is truly needed?

It's for sure needed. That's the version that is used with .NET Core

Or perhaps I misunderstood your question?

My own lib, which depends on HAP, is NetStandard 1.1 and i would not want to rise it to 1.6.
Do you have some guidance about that?

pendenaor commented Jun 6, 2017

May i ask you if NetStandard 1.6 is truly needed?

It's for sure needed. That's the version that is used with .NET Core

Or perhaps I misunderstood your question?

My own lib, which depends on HAP, is NetStandard 1.1 and i would not want to rise it to 1.6.
Do you have some guidance about that?

@JonathanMagnan

This comment has been minimized.

Show comment
Hide comment
@JonathanMagnan

JonathanMagnan Jun 6, 2017

Member

The problem about .NETStandard 1.1 is almost nothing is supported that library requires.

By example, 3 of 4 packages on which HAP depend require .NETStandard 1.3 minimum:

So it could be possible to create a .NETStandard 1.3 packages but 1.1 will be close to impossible I believe since we don't have access to package required.

If we remove theses dependencies, I'm not sure how many functionalities we will remove!

We will soon support CSS Selectors like jQuery. Perhaps after we support it, I could check to see about the support for 1.1

You will not have access to XPath selectors, but at least you will have access to CSS Selectors.

Best Regards,

Jonathan

Member

JonathanMagnan commented Jun 6, 2017

The problem about .NETStandard 1.1 is almost nothing is supported that library requires.

By example, 3 of 4 packages on which HAP depend require .NETStandard 1.3 minimum:

So it could be possible to create a .NETStandard 1.3 packages but 1.1 will be close to impossible I believe since we don't have access to package required.

If we remove theses dependencies, I'm not sure how many functionalities we will remove!

We will soon support CSS Selectors like jQuery. Perhaps after we support it, I could check to see about the support for 1.1

You will not have access to XPath selectors, but at least you will have access to CSS Selectors.

Best Regards,

Jonathan

@pendenaor

This comment has been minimized.

Show comment
Hide comment
@pendenaor

pendenaor Jun 7, 2017

Thanks for your thorough answer.
Thinking back on it, NetStandard 1.3 sounds good to me.

Best regards,
Stéphane.

pendenaor commented Jun 7, 2017

Thanks for your thorough answer.
Thinking back on it, NetStandard 1.3 sounds good to me.

Best regards,
Stéphane.

@JonathanMagnan

This comment has been minimized.

Show comment
Hide comment
@JonathanMagnan

JonathanMagnan Jun 7, 2017

Member

Great, we will try to support .NET Standard 1.3 during the weekend.

Best Regards,

Jonathan

Member

JonathanMagnan commented Jun 7, 2017

Great, we will try to support .NET Standard 1.3 during the weekend.

Best Regards,

Jonathan

@JonathanMagnan

This comment has been minimized.

Show comment
Hide comment
@JonathanMagnan

JonathanMagnan Jun 17, 2017

Member

Hello @pendenaor ,

We added support to the .NET Standard 1.3,

The new version should be available within a few hours.

Best Regards,

Jonathan

Member

JonathanMagnan commented Jun 17, 2017

Hello @pendenaor ,

We added support to the .NET Standard 1.3,

The new version should be available within a few hours.

Best Regards,

Jonathan

@JonathanMagnan

This comment has been minimized.

Show comment
Hide comment
@JonathanMagnan

JonathanMagnan Jun 17, 2017

Member

Hello @jonalbrecht , @pendenaor

The version v1.5.0-beta9 has been released:
https://www.nuget.org/packages/HtmlAgilityPack/1.5.0-beta9

Let us know if the support to .NET Standard 1.3 work correctly

Best Regards,

Jonathan

Member

JonathanMagnan commented Jun 17, 2017

Hello @jonalbrecht , @pendenaor

The version v1.5.0-beta9 has been released:
https://www.nuget.org/packages/HtmlAgilityPack/1.5.0-beta9

Let us know if the support to .NET Standard 1.3 work correctly

Best Regards,

Jonathan

@pendenaor

This comment has been minimized.

Show comment
Hide comment
@pendenaor

pendenaor Jun 21, 2017

Sorry for the delay!
I'll test it soon.

pendenaor commented Jun 21, 2017

Sorry for the delay!
I'll test it soon.

@JonathanMagnan

This comment has been minimized.

Show comment
Hide comment
@JonathanMagnan

JonathanMagnan Jun 27, 2017

Member

Closing Comment: Feel free to re-open if you still have an issue.

Member

JonathanMagnan commented Jun 27, 2017

Closing Comment: Feel free to re-open if you still have an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment