Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$ in comment text breaks NeV comments #34

Open
TomekFraczek opened this issue Feb 28, 2024 · 0 comments
Open

$ in comment text breaks NeV comments #34

TomekFraczek opened this issue Feb 28, 2024 · 0 comments

Comments

@TomekFraczek
Copy link

TomekFraczek commented Feb 28, 2024

Text for any comment packets that include $ are not parsed as expected.

This is seems to be a result of lines 739-744 in brpylib.py. The char arrays for all comment text are concatenated together, with $ as a separator. They are then decoded and cleaned as a single unit, and split back up at $. As a result, the comment text for any comment that includes a $ is split into two comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant