Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lane arrows when ban private cars on bus lanes is enabled #1656

Open
sidboy55555 opened this issue Sep 26, 2022 · 8 comments
Open

Lane arrows when ban private cars on bus lanes is enabled #1656

sidboy55555 opened this issue Sep 26, 2022 · 8 comments
Labels
enhancement Improve existing feature LANE ROUTING Feature: Lane arrows / connectors

Comments

@sidboy55555
Copy link

When having "Ban private cars and trucks on bus lanes" enabled, the lane arrows of the roads don't change, and so cars on the normal lane won't be able to turn right, unless you manually change the arrows on the road.

Maybe make an setting that takes it in account when creating a road when having this enabled?

@sidboy55555 sidboy55555 added feature A new distinct feature triage Awaiting issue categorisation labels Sep 26, 2022
@krzychu124 krzychu124 added enhancement Improve existing feature LANE ROUTING Feature: Lane arrows / connectors and removed feature A new distinct feature triage Awaiting issue categorisation labels Oct 2, 2022
@krzychu124
Copy link
Member

@kianzarrin what do you think about this suggestion?

@kianzarrin
Copy link
Collaborator

we need to import ILC2 mod into TMPE with support for TMPE features.
if memory serves I think the dedicated turning lane policy takes "Ban private cars and trucks on bus lanes" into consideration.

@kianzarrin
Copy link
Collaborator

I just don't like the fact that we have to update all lane arrows when such options are enabled. it slows down loading time. maybe if TMPE was loaded earlier when simulation data is ready could solve this problem?

@krzychu124
Copy link
Member

I think that's the way how it should be done - on load apply settings without requesting an update, so other mods will see our changes already and if they change something they can trigger update and our code will run if necessary.
With regards to the OP issue we don't update arrows which can cause pathfinding problems like mentioned and I don't think we could avoid mass update in that case (although should be limited only to segments with bus lane)

@ZzZombo
Copy link

ZzZombo commented Feb 20, 2023

image
image
Still an issue. The first image shows how the arrows are allocated w/o dedicated turning lanes. The second is after I enabled them. Note that it still fails to correctly arrange them all, namely the bus lane can't turn left as is. Interestingly the opposite direction doesn't have this problem.

@krzychu124
Copy link
Member

Still an issue. The first image shows how the arrows are allocated w/o dedicated turning lanes. The second is after I enabled them. Note that it still fails to correctly arrange them all, namely the bus lane can't turn left as is. Interestingly the opposite direction doesn't have this problem.

Have you tested it in-game (new game or loaded savegame)? Things in the Editor are not behaving the same as in normal game :/

@ZzZombo
Copy link

ZzZombo commented Feb 20, 2023

I did observe this first outside the editor.

@side777
Copy link

side777 commented Feb 26, 2023

I have done some tests with vanilla roads and custom roads (build with road builder and from the workshop). Problem is, that road builder creates roads with banned cars on bus lanes by default. Also some workshop roads do this. So even if the option to ban cars is disabled in TM:PE the dedicated turning lane option will break traffic with those custom roads. Interestingly the vanilla game is allowing dedicated bus lanes on custom roads to take all directions - while the car lanes may or may not get a turning lane depending on the number of lanes of the destination road.

Vanilla roads and custom road with dedicated turning lanes OFF:

Screenshot 18
(Note that I turned off the all direction arrow prop on the bus lane but the lane gets all directions, I double checked.)

And dedicated turning lanes ON:

Screenshot 19

One solution would be the check if a lane actually is allowing cars. This could be because of a custom road, the ban cars option or manually banned cars on that lane. So this would solve all possible cases and not only the case of enabled ban cars option.

In my tests ILC2 is working as intended in all scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing feature LANE ROUTING Feature: Lane arrows / connectors
Projects
None yet
Development

No branches or pull requests

5 participants