Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in pool.py, Connection class #1

Open
gianpaolo-lopresti opened this issue Sep 30, 2015 · 4 comments
Open

Bug in pool.py, Connection class #1

gianpaolo-lopresti opened this issue Sep 30, 2015 · 4 comments
Assignees
Labels

Comments

@gianpaolo-lopresti
Copy link

Hi,
the method Connection.send_cmd_all() (pool.py) calls host.mark_dead(msg) on a socket.error: but the Host class doesn't implement such method, so the AttributeError is raised.

I have written this method in the Host class (host.py):

def mark_dead(self, msg):
    logging.error(msg)
    self.close_socket()

I don't know if this could be a solution, but it seems to work.

@ErDmKo ErDmKo self-assigned this Sep 30, 2015
@ErDmKo ErDmKo added the bug label Sep 30, 2015
@ErDmKo
Copy link
Owner

ErDmKo commented Sep 30, 2015

@gianpaolo-lopresti thanks for your feedback. I will try to make test to repeat it. I have some idea when it can happen.

@gianpaolo-lopresti
Copy link
Author

@ErDmKo a sample use case is to have continuous calls to the memcache service (i used a for loop with a sleep() at the end to simulate a production environment), while the memcache deamon is restarted.

@ErDmKo
Copy link
Owner

ErDmKo commented Oct 1, 2015

@gianpaolo-lopresti thank again
Now i add new commit 5f28566 and up version in pypi. Than next time i will do try to reconnect than case after "DEAD_RETRY" seconds.

@gianpaolo-lopresti
Copy link
Author

Thanks a lot @ErDmKo !! Bye!

jacksontj added a commit to jacksontj/asyncmc that referenced this issue Nov 30, 2017
Add multi operators to client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants