Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Advancement Criteria Injection #3621

Open
maityyy opened this issue Feb 27, 2024 · 0 comments
Open

[Suggestion] Advancement Criteria Injection #3621

maityyy opened this issue Feb 27, 2024 · 0 comments

Comments

@maityyy
Copy link
Contributor

maityyy commented Feb 27, 2024

There are many vanilla advancements like "kill all hostile mobs" or "traverse all nether biomes" — and also many mods that add new "hostile mobs" and "nether biomes", but they cannot support the vanilla advancements together. The only way is to overwrite the advancement file, which can only be done once and by one mod.

I suggest adding something like LootTableEvents but for AdvancementEntry, which contains the Advancement itself and its Identifier, which will also allow us to select the advancement we want. It seems that ServerAdvancementLoader and PlayerAdvancementTracker are pretty similar to LootManager(Mixin). The only thing we'd have to think about a bit is sync with the client, but I'm not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant