Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water/Foliage Color Modification Not Working #3650

Open
AViewFromTheTop opened this issue Mar 15, 2024 · 5 comments
Open

Water/Foliage Color Modification Not Working #3650

AViewFromTheTop opened this issue Mar 15, 2024 · 5 comments

Comments

@AViewFromTheTop
Copy link

Has stopped working for quite a while. Only seems to impact modded biomes.

@modmuss50
Copy link
Member

Have you got a minimal way to reproduce this? How are you adding the modded biome?

@AViewFromTheTop
Copy link
Author

Have you got a minimal way to reproduce this? How are you adding the modded biome?

I'm registering them through datagen.
We do have a custom FrozenBiome class, but it's the same as how vanilla builds its biomes- just streamlined into separate classes.
Screenshot_20240316_211406

2024-03-16_21 15 42

BiomeModifications.create(WilderSharedConstants.id("modify_hot_water")).add( ModificationPhase.REPLACEMENTS, BiomeSelectors.all(), (selectionContext, modificationContext) -> { BiomeModificationContext.EffectsContext context = modificationContext.getEffects(); context.setWaterColor(0); context.setWaterFogColor(0); });

@AViewFromTheTop
Copy link
Author

AViewFromTheTop commented Mar 17, 2024

Screenshot_20240316_211644
If a screenshot's easier, here it is.
It only works on biomes we've added, nothing else.

@AViewFromTheTop
Copy link
Author

Seems to only impact 1.20.5 versions.

@dayofpi
Copy link

dayofpi commented Apr 27, 2024

I'm having almost the same issue in 1.20.5 release, I call this in my modinitializer but it doesn't change the grass color

        BiomeModifications.create(new Identifier(Bitty.MOD_ID, "birch_overhaul"))
                .add(ModificationPhase.REPLACEMENTS, biomeSelectionContext -> BittyConfig.birchOverhaul && biomeSelectionContext.hasTag(ConventionalBiomeTags.IS_BIRCH_FOREST), context -> {
                    context.getEffects().setGrassColor(10475854);
                });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants