Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going to resource packs then clicking done causes resource reload #3656

Open
mrjasonn opened this issue Mar 18, 2024 · 6 comments
Open

Going to resource packs then clicking done causes resource reload #3656

mrjasonn opened this issue Mar 18, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@mrjasonn
Copy link

mrjasonn commented Mar 18, 2024

Going to resource packs menu then clicking done causes resource reload, but only for every time you launch the game. This has been tested on Minecraft 1.20.6 with Fabric API 0.97.8.
This bug is separate from MC-264307 as I have mentioned that the issue in Fabric API is that it happens every time you launch the game.

@modmuss50 modmuss50 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Mar 18, 2024
@modmuss50
Copy link
Member

I can reproduce this in 1.20.4

@apple502j apple502j removed the priority:high High priority PRs that need review and work now. Review these first. label Mar 18, 2024
@haykam821
Copy link
Contributor

Is this issue separate from a similar vanilla issue that also causes resource reloading when clicking the 'Done' button?

@mrjasonn
Copy link
Author

mrjasonn commented Mar 19, 2024

Is this issue separate from a similar vanilla issue that also causes resource reloading when clicking the 'Done' button?

different from vanilla one, as [Mod] Greymagic27 said in the mojang one:

I was able to reproduce this only when I've first loaded up the game and went there. It displayed the red Mojang loading screen for 2 seconds or so.

After that I couldn't reproduce without relaunching again, and then it only did it once.

so it is separate from the Fabric API one in how it works because the Fabric API one is every time launch the game

@MCLegoMan
Copy link

When entering the resource pack screen, the game will disable resource packs that have been registered through fabric api, thus when pressing done it will reload the resources. If you re-enable the resources that were already enabled, the resources won't reload.

From my testing, this seems to happen no matter the activation type.

I am currently using fabric-api 0.97.3+1.20.5, with fabric loader 0.15.10, on 1.20.5-pre4, but this issue has been happening throughout the 1.20.5 snapshots.

@mrjasonn
Copy link
Author

Now checked on 1.20.5, still same issue

@mrjasonn
Copy link
Author

mrjasonn commented May 1, 2024

1.20.6 is also affected (API ver 0.97.8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants