Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leather item tag for convention-tags-v2 #3731

Open
dhyces opened this issue Apr 23, 2024 · 3 comments
Open

Leather item tag for convention-tags-v2 #3731

dhyces opened this issue Apr 23, 2024 · 3 comments

Comments

@dhyces
Copy link

dhyces commented Apr 23, 2024

Would be nice to have for mods that add "leathers" comparable to regular leather.

@TelepathicGrunt
Copy link
Contributor

TelepathicGrunt commented Apr 27, 2024

It’s in the Neo side already.
https://github.com/neoforged/NeoForge/blob/c36a5ea78012784398ef93ebf1faf0a6e6913c72/src/main/java/net/neoforged/neoforge/common/data/internal/NeoForgeItemTagsProvider.java#L135

Forgot about fabric side but seems good for someone to PR to add it. I guess I skipped it over due to only finding one mod using a similar tag on fabric. But if more are gonna use it, let’s add it to fabric side to match neo
IMG_0892

would be c:leathers

@dhyces
Copy link
Author

dhyces commented Apr 28, 2024

It’s in the Neo side already.
https://github.com/neoforged/NeoForge/blob/c36a5ea78012784398ef93ebf1faf0a6e6913c72/src/main/java/net/neoforged/neoforge/common/data/internal/NeoForgeItemTagsProvider.java#L135

Forgot about fabric side but seems good for someone to PR to add it. I guess I skipped it over due to only finding one mod using a similar tag on fabric. But if more are gonna use it, let’s add it to fabric side to match neo
IMG_0892

would be c:leathers

It's c:leather in neo

@TelepathicGrunt
Copy link
Contributor

As per the field name, it should be leathers. I’ll make issue report to Neo as nouns should be plural

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants