Allow passing multiple BiomeTags at the same time for BiomeSelectors #3695
Conversation
|
Does creating a tag that references other tags not work for your use case? In most cases, |
|
You could do that but I feel like it's unnecessary and you'd need to make tags for every combo you do |
| /** | ||
| * {@return true if this biome is in any of the given {@link TagKey}s}. | ||
| */ | ||
| default boolean hasTag(TagKey<Biome>... tags) { |
There was a problem hiding this comment.
It doesn't sound obvious. I think we need to add anyTagMatch, allTagMatch and noneTagMatch
There was a problem hiding this comment.
I agree I think something like this would be ideal here
There was a problem hiding this comment.
*To be clear: I'm suggesting the same thing as Stream::anyMatch, Stream::allMatch, Stream::noneMatch
|
Hmm, can't we just use |
We can, but we have convenient helper methods and the author suggests expanding it |
|
I'm unsure how useful this boilerplate code is, as pointed about above this is really easy to do in your own mod with |
modmuss50
added
small change
priority:low
I have run into situations where with ores for example I want to add them to more than one biomeTag biomes and have to make a separate entry, this solves that by allowing developers to pass in more than one.