[1.20.4] Alter StartTracking with Before and After Variants #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking - Keep binary compatibility with the old field marking such as deprecated
modmuss50
reviewed
Apr 10, 2024
...working-api-v1/src/main/java/net/fabricmc/fabric/api/networking/v1/EntityTrackingEvents.java
Outdated
Show resolved
Hide resolved
| * @deprecated Use {#BEFORE_START_TRACKING} or {@link #AFTER_START_TRACKING} instead | ||
| */ | ||
| @Deprecated(forRemoval = true) | ||
| public static final Event<BeforeStartTracking> START_TRACKING = BEFORE_START_TRACKING; |
There was a problem hiding this comment.
I would prob just leave this a tottaly seperate event, and keep it the same as it was before.
There was a problem hiding this comment.
Little clarification, do you mean:
- Keep the original Event as it was but with deprecation while also adding the specific before and after variants
OR - Keep the original Event but add the after-variant as the only addition
There was a problem hiding this comment.
Think it's no. 2; start tracking and after start tracking events.
There was a problem hiding this comment.
Hi, sorry. I was more thinking about 1:
Keep the current event untouched, no need to try and be clever about ensuring backwards compatibility just duplicate it. You would then end up with:
- BEFORE_START_TRACKING
- START_TRACKING (existing, deprecated)
- AFTER_START_TRACKING
There was a problem hiding this comment.
I did ensure the code was backward compatible but made the desired adjustment to the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Point of this PR is to have an After Variant for StartTracking as the current implementation calls the
StartTrackingevent before any packets for the Entity's creation making such an event pointless if you need to sync things like data attachment to the Client as such will require some delayed method of handling any packet sent until the entity exists. Evidence of such an event being useful can be found within Cardinal Components and NeoForge.Additionally, this PR attempts to keep binary compatibility with previous API versions with such old variants extending the renaming of the old event.