Add c:indestructible tag #3758
Open
Add c:indestructible tag #3758
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to add tag translation to EnglishTagLangGenerator as well as making this tag in the normal datagen file. That way the tag has a translation and has a blank json file made for people that look at the json rather than the tag classes. Better visibility that way |
This was referenced May 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the c:indestructible tag to items.
This tag is there to represent items which shall not be destroyed.
I don't know if c:indestructible is the correct naming. But I don't have a better idea.
I have not added a block tag. As I would be unsure if bedrock would go into it? For some mods bedrock may be considered as destructible.
A different idea would be to use fabric:indestructible and change all the vanilla cases where items are destroyed or used in crafting. But this would likely be to out of scope for fabric-api.