-
Notifications
You must be signed in to change notification settings - Fork 31
recording should save itself right before phone dies #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Please adjust your feature request report to the issue template. |
it's self-explanatory, there is no description to be added |
Everyone can tell that their issues are self-explanatory and just ignore the template, and then others will point this issue as an example that template is not required by us. At least fill the checklist. Also, you could add, e.g. whether you'd like to have this in settings. |
I think a simpler solution would be to just charge the phone before recording given that most phones will remind you when your battery is low. I'm closing this... |
sometimes theres no charge, life happens and people get unlucky. it's your call but it would make sensw for this to be tagged 'needs help' rather than closed. |
I would like feature too tbh, things happen |
@RustoMCSpit all of your issues in this repo are still not formatted according to the issue templates even after we notified you. Seems like you also ignored the following line present in the issue templates:
Please consider closing your issues and raising new ones with proper info using the new issue form options. Otherwise, I'll probably close your issues simply to enforce the same rules on everyone.
Things happen but this is an edge case. Why would you ignore the system warnings to charge your phone? I think this is one of those little things in life that teach us that actions (or lack thereof) have consequences but you are welcome to raise a new feature request with the proper format. I'm not reopening this empty issue.
Backups protect against unpredictable things like hardware failures, virus attacks, and other disasters. Your phone losing all its charge isn't on the same level and is pretty predictable. |
As mentioned in #5 (comment), I am closing all issues with missing templates. |
"Why wear a phone case? Just don't drop your phone..." The whole point of safeguards is to correct for human error such as forgetting to charge.
Everything must be done to prevent file corruption, even in "edge cases".
Your goal should be to make the app as good as possible, not punishing users to "teach them lessons". I love your work and I wholeheartedly thank you for running this project, but I have to disagree here. Please reconsider your standpoint. |
Thanks but again, I have to disagree with the analogy here:
Phones usually do not issue warnings to put on a case, they just fall.
There is no "us vs them", I am one of the users. Anyway, this should already be working as a side effect of #74. |
This seems to be the case for MP3 and OPUS, but M4A files that were not saved properly have no "moov atom" at the end and require manual recovery. An alternative to saving before the battery runs out might be to add a feature to recover a broken M4A file after the next reboot or when starting the app the next time. Samsung's own voice recorder seems to try to do that, but isn't always successful. |
#87 would require that to be implemented. |
No description provided.
The text was updated successfully, but these errors were encountered: