Skip to content

recording should save itself right before phone dies #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RustoMCSpit opened this issue Dec 4, 2023 · 13 comments
Closed

recording should save itself right before phone dies #5

RustoMCSpit opened this issue Dec 4, 2023 · 13 comments
Labels
template ignored The user didn't follow the template/instructions (or removed them)

Comments

@RustoMCSpit
Copy link

No description provided.

@Aga-C
Copy link
Member

Aga-C commented Dec 7, 2023

Please adjust your feature request report to the issue template.

@Aga-C Aga-C added feature request Issue is about a new feature or improving existing feature/behavior. waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. template ignored The user didn't follow the template/instructions (or removed them) labels Dec 8, 2023
@Aga-C Aga-C added needs triage Issue is not yet ready for PR authors to take up and removed waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. labels Dec 19, 2023
@RustoMCSpit RustoMCSpit changed the title recording should save itself right before phone dies # recording should save itself right before phone dies Jan 1, 2024
@RustoMCSpit RustoMCSpit changed the title recording should save itself right before phone dies recording should save itself right before phone dies Jan 1, 2024
@RustoMCSpit
Copy link
Author

RustoMCSpit commented Jan 1, 2024

Please adjust your feature request report to the issue template.

it's self-explanatory, there is no description to be added

@Aga-C
Copy link
Member

Aga-C commented Jan 1, 2024

Everyone can tell that their issues are self-explanatory and just ignore the template, and then others will point this issue as an example that template is not required by us.

At least fill the checklist. Also, you could add, e.g. whether you'd like to have this in settings.

@inson1
Copy link

inson1 commented Jan 2, 2024

@naveensingh
Copy link
Member

I think a simpler solution would be to just charge the phone before recording given that most phones will remind you when your battery is low. I'm closing this...

@naveensingh naveensingh closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
@naveensingh naveensingh removed feature request Issue is about a new feature or improving existing feature/behavior. needs triage Issue is not yet ready for PR authors to take up template ignored The user didn't follow the template/instructions (or removed them) labels Feb 13, 2024
@Aga-C Aga-C added the invalid This does not seem right label Feb 13, 2024
@RustoMCSpit
Copy link
Author

I think a simpler solution would be to just charge the phone before recording given that most phones will remind you when your battery is low. I'm closing this...

sometimes theres no charge, life happens and people get unlucky. it's your call but it would make sensw for this to be tagged 'needs help' rather than closed.

@inson1
Copy link

inson1 commented Feb 18, 2024

I would like feature too tbh, things happen
its same as
Why do backups? just dont break it and dont loose it

@naveensingh
Copy link
Member

@RustoMCSpit all of your issues in this repo are still not formatted according to the issue templates even after we notified you. Seems like you also ignored the following line present in the issue templates:

"[ ] I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise."

Please consider closing your issues and raising new ones with proper info using the new issue form options. Otherwise, I'll probably close your issues simply to enforce the same rules on everyone.


sometimes theres no charge, life happens and people get unlucky.

Things happen but this is an edge case. Why would you ignore the system warnings to charge your phone? I think this is one of those little things in life that teach us that actions (or lack thereof) have consequences but you are welcome to raise a new feature request with the proper format. I'm not reopening this empty issue.

Why do backups? just dont break it and dont loose it

Backups protect against unpredictable things like hardware failures, virus attacks, and other disasters. Your phone losing all its charge isn't on the same level and is pretty predictable.

@Aga-C Aga-C added template ignored The user didn't follow the template/instructions (or removed them) and removed invalid This does not seem right labels Feb 20, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 21, 2024

As mentioned in #5 (comment), I am closing all issues with missing templates.

@HT-7
Copy link

HT-7 commented Feb 12, 2025

I think a simpler solution would be to just charge the phone

"Why wear a phone case? Just don't drop your phone..."

The whole point of safeguards is to correct for human error such as forgetting to charge.

Things happen but this is an edge case.

Everything must be done to prevent file corruption, even in "edge cases".

I think this is one of those little things in life that teach us that actions (or lack thereof) have consequences

Your goal should be to make the app as good as possible, not punishing users to "teach them lessons".

I love your work and I wholeheartedly thank you for running this project, but I have to disagree here. Please reconsider your standpoint.

@naveensingh
Copy link
Member

Thanks but again, I have to disagree with the analogy here:

"Why wear a phone case? Just don't drop your phone..."

Phones usually do not issue warnings to put on a case, they just fall.

"teach them lessons".

There is no "us vs them", I am one of the users.

Anyway, this should already be working as a side effect of #74.

@HT-7
Copy link

HT-7 commented Mar 11, 2025

Anyway, this should already be working as a side effect of #74.

This seems to be the case for MP3 and OPUS, but M4A files that were not saved properly have no "moov atom" at the end and require manual recovery.

An alternative to saving before the battery runs out might be to add a feature to recover a broken M4A file after the next reboot or when starting the app the next time. Samsung's own voice recorder seems to try to do that, but isn't always successful.

@naveensingh
Copy link
Member

recovering broken recordings

#87 would require that to be implemented.

@naveensingh naveensingh mentioned this issue Mar 28, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template ignored The user didn't follow the template/instructions (or removed them)
Projects
None yet
Development

No branches or pull requests

5 participants