Add base64 and csv gems to Gemfile #17342
Closed
+403
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added a commit
that referenced
this pull request
May 21, 2024
This (incorrectly) removes gems that are also part of the system Ruby e.g. `base64` which contradicts warnings from Ruby itself when `require`ing these gems. Extracted from #17342 as this needs to be in `master` for that PR's vendored gems job to pass.
These will be needed with Ruby 3.4 and base64 is blocking #16893. Relatedly: - don't use `HOMEBREW_BOOTSNAP` by default in all CI jobs. We can add it back one-by-one where necessary but as-is it's breaking too much with `base64` - ensure that `csv` gem is not committed and optionally installed on demand by `brew contributions --csv` - no longer hide warnings about base64/csv requires
MikeMcQuaid
force-pushed
the
add_base64_csv_gems
branch
from
8d78c87
to
c1b8d63
Compare
|
Passing on this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be needed with Ruby 3.4 and base64 is blocking #16893.
Relatedly:
HOMEBREW_BOOTSNAPby default in all CI jobs. We can add it back one-by-one where necessary but as-is it's breaking too much withbase64csvgem is not committed and optionally installed on demand bybrew contributions --csvbundle cleanbecause it can remove gems we need