Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of ColumnTransformer and make_column_transformer #452

Open
ArturoAmorQ opened this issue Sep 6, 2021 · 1 comment
Open
Milestone

Comments

@ArturoAmorQ
Copy link
Collaborator

Most of the notebooks use ColumnTransformer

glossary.md
predictive_modeling_module_take_away.md:
wrap_up_quiz 1
03_categorical_pipeline_column_transformer.py
03_categorical_pipeline_ex_02.py
03_categorical_pipeline_sol_02.py
parameter_tuning_ex_02.py and parameter_tuning_sol_02.py
parameter_tuning_ex_03.py and parameter_tuning_sol_03.py
parameter_tuning_grid_search.py
parameter_tuning_nested.py
parameter_tuning_randomized_search.py

On the other hand, make_column_transformer is only used in

ensemble_random_forest.py
wrap_up_quiz 1
wrap_up_quiz 4
wrap_up_quiz 5

I recommend keeping either one or the other to avoid possible confusion.
Keeping make_column_transformer means more editing in the present contents but will reduce variance naming (and therefore calling) the transformers. What do you think?

@glemaitre
Copy link
Collaborator

I recommend keeping either one or the other to avoid possible confusion.

I would use both but make sure that we present both. We should have the same issue with Pipeline and make_pipeline. I see that we do a slightly better job stating that make_pipeline is creating a Pipeline. But I think it would be worth showing how to create a Pipeline directly.

The reason to use both is that there are time where you want to use one or another, specifically.

@lesteve lesteve added this to the MOOC 3.0 milestone Jan 6, 2022
@lesteve lesteve modified the milestones: MOOC 3.0, MOOC 4.0 Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants