Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jupyterlab-myst #742

Open
lesteve opened this issue Oct 26, 2023 · 3 comments
Open

Use jupyterlab-myst #742

lesteve opened this issue Oct 26, 2023 · 3 comments

Comments

@lesteve
Copy link
Collaborator

lesteve commented Oct 26, 2023

https://github.com/executablebooks/jupyterlab-myst

This allows to use MyST inside a Jupyter notebook.

This would allow to get rid of replace_admonition in https://github.com/INRIA/scikit-learn-mooc/blob/main/build_tools/convert-python-script-to-notebook.py to turn MyST admonitions into HTML

@ArturoAmorQ
Copy link
Collaborator

Somewhat related to this issue (though not sure jupyter-mist would solve it): the generated notebooks changed behavior of rendered admonitions.

FUN session 3:

Screenshot 2023-10-27 at 15-24-51 Linear regression with non-linear link between data and target Modelling non-linear features-target relationships 41026 Courseware FUN-MOOC

FUN session 4:

Screenshot 2023-10-27 at 15-24-33 Non-linear feature engineering for Linear Regression Non-linear feature engineering for linear models 41026 Courseware FUN-MOOC

@lesteve
Copy link
Collaborator Author

lesteve commented Nov 6, 2023

I have regenerated the notebooks which should fix the issue.

New notebook: https://github.com/INRIA/scikit-learn-mooc/blob/main/notebooks/linear_regression_non_linear_link.ipynb

Old notebook: https://github.com/INRIA/scikit-learn-mooc/blob/5cc989e98fb8251b2f3e7df08c783ff9f2e592e4/notebooks/linear_regression_non_linear_link.ipynb

This was done in #743 since it looks like notebooks have been generated directly with jupytext. This does not have the logic to generate the HTML admonitions, you need to run the full script ...

@ogrisel
Copy link
Collaborator

ogrisel commented Nov 6, 2023

make notebooks should work when run from scratch. But if a given notebook was updated more recently by jupytext, then make might see that it's already up to date (based on the .ipynb last write access date) and then mistakenly things it can be skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants