Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A suggestion regarding fixing the ambiguous package problem #5475

Open
WarpspeedSCP opened this issue Sep 27, 2023 · 1 comment · May be fixed by #5520
Open

A suggestion regarding fixing the ambiguous package problem #5475

WarpspeedSCP opened this issue Sep 27, 2023 · 1 comment · May be fixed by #5520

Comments

@WarpspeedSCP
Copy link

WarpspeedSCP commented Sep 27, 2023 •
edited

At work, I got quite tired of seeing exceptions caused by ambiguous package names in user code. So I made a fix for the issue by merging such packages together, and deleting duplicated packages.

Here's the change:
WarpspeedSCP@1e62e4b

What I'd like to explore is if it makes sense to take it forward, as this had actually helped in improving support for packages that are split across multiple source roots.
@WarpspeedSCP
Copy link
Author

there are unfortunately no tests in spoon itself but the changes have been tested within DeepSource's Java analyser.

@WarpspeedSCP WarpspeedSCP linked a pull request Oct 25, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] fix: Merge ambiguous packages instead of throwing an error WarpspeedSCP/spoon
1 participant
@WarpspeedSCP